Pass through the cache context to the vulnerability resource #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
force-pushed
the
dev-nkolev92-vulnerabilityAPICleanup
branch
from
8ec91f3 to
6bcba8f
Compare
donnie-msft
previously approved these changes
Aug 15, 2023
src/NuGet.Core/NuGet.Commands/RestoreCommand/VulnerabilityInformationProvider.cs
Show resolved
Hide resolved
zivkan
reviewed
Aug 15, 2023
martinrrm
previously approved these changes
Aug 15, 2023
jeffkl
requested changes
Aug 16, 2023
…rability resource
aortiz-msft
requested review from
donnie-msft,
jeffkl,
martinrrm,
zivkan and
aortiz-msft
aortiz-msft
requested changes
Aug 17, 2023
nkolev92
force-pushed
the
dev-nkolev92-vulnerabilityAPICleanup
branch
from
6bcba8f to
be591a4
Compare
nkolev92
changed the title
|
@jeffkl @aortiz-msft Addressed all feedback. |
jeffkl
previously approved these changes
Aug 18, 2023
zivkan
previously approved these changes
Aug 18, 2023
aortiz-msft
previously approved these changes
Aug 18, 2023
nkolev92
dismissed stale reviews from aortiz-msft, zivkan, and jeffkl
via
2c08b40
zivkan
approved these changes
Aug 19, 2023
donnie-msft
pushed a commit
that referenced
this pull request
Aug 25, 2023
zivkan
added a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2432
Regression? Last working version:
Description
The VulnerabilityInformationProvider creates redundant SourceCacheContext. We should reuse the same SourceCacheContext throughout the whole operation.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation