Update VS Options add/remove package source icons to VS2022 styling

[timheuer]

Bug

Fixes: NuGet/Home#12840

Regression? No

Description

This updates only the imagelist16/32/64 base64 encoded image for up/down/cancel/add images used in Package Source UI in VS2022. Source of new images are from the VS2022 KnownMonikers for MoveUp, MoveDown, Add, Cancel and match visuals of these type of actions elsewhere in VS2022.

Before:

After:

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[zivkan]

Using the "KnownMonikers Explorer" extension, I see that VS already has icons for Add, Cancel, MoveUp, and MoveDown. You pointed out in the PR description that these icons already exist in VS as KnownMonikers. VS extensibility also have docs on how to use it in WinForms: https://learn.microsoft.com/en-us/visualstudio/extensibility/image-service-and-catalog?view=vs-2022#how-do-i-update-winforms-ui

So, should we delete these icons from NuGet's resx, and use VS's built-in icons?

[timheuer]

So, should we delete these icons from NuGet's resx, and use VS's built-in icons?

Honestly probably, but also I PR'd probably the smallest impact change...just the base64, no code, no DPI change, etc. -- I'd imagine changing to other means would be more code and then y'all would question the value of the change. I felt this was simplest to get there.

[aortiz-msft]

Thank you for the contribution.

[donnie-msft]

Tried it out and looks good! Thanks for helping us out!

[donnie-msft]

The issue this closes mentions arrow icons, which I'm not sure I see in my testing. Left a comment here NuGet/Home#12840 (comment)

Once that's clarified, I'll merge. Thanks again!