Add a utility for checking vulnerabilities during packages.config restore #5383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12852
Regression? Last working version:
Description
This PR adds the core code for adding vulnerability checking for package.config restore.
This change is just a 1st part of PC vulnerability checking.
This PR mimics some of the work in https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/AuditUtility.cs, but it adds more explicit test coverage for the methods.
Note that I did make small changes in the NuGet.Commands code. These changes shorten the code and match the implementation in the PR side.
I didn't want to create a public class as I have no proposal better than a bunch of statics. As we add more scenarios such as vulnerability checking during package installation, we'll be able to create better APIs.
Reasons why this PR doesn't enable the feature.
Note
I did test that this API works well and is sufficient for the purposes of packages.config restore vulnerability reporting.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation