Change Apex tests from Xunit to MSTest #5428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9a3d091.
|
OMG! The pipeline didn't timeout, and other tests actually ran!!!
|
dtivel
reviewed
Sep 29, 2023
test/NuGet.Tests.Apex/NuGet.Tests.Apex/Apex/SharedVisualStudioHostTestClass.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Tests.Apex/NuGet.Tests.Apex/Apex/SharedVisualStudioHostTestClass.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Tests.Apex/NuGet.Tests.Apex/NuGetEndToEndTests/IVsServicesTestCase.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Tests.Apex/NuGet.Tests.Apex/NuGetEndToEndTests/NetCoreProjectTestCase.cs
Outdated
Show resolved
Hide resolved
| @@ -22,12 +21,15 @@ public class IVsServicesTestCase : SharedVisualStudioHostTestClass, IClassFixtur | |||
|
|
|||
| private readonly SimpleTestPathContext _pathContext = new SimpleTestPathContext(); | |||
|
|
|||
| public IVsServicesTestCase(VisualStudioHostFixtureFactory visualStudioHostFixtureFactory, ITestOutputHelper output) | |||
| : base(visualStudioHostFixtureFactory, output) | |||
| private const int Timeout = 5 * 60 * 1000; // 5 minutes | |||
There was a problem hiding this comment.
We can move this to a shared location as a global default and reuse it everywhere, instead of redefining Timeout in every test class. On a case-by-case basis, we can override the default.
There was a problem hiding this comment.
Thanks! Moved it to test/NuGet.Tests.Apex/NuGet.Tests.Apex/Apex/SharedVisualStudioHostTestClass.cs
test/NuGet.Tests.Apex/NuGet.Tests.Apex/NuGetEndToEndTests/NetCoreProjectTestCase.cs
Outdated
Show resolved
Hide resolved
heng-liu
deleted the
dev-hengliu-CI-changeApex-mstest-enableAllApex-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2379
Regression? Last working version:
Description
Background
MSTest is able to time out individual Apex test, and it could attach files for diagnosing the flakiness. So we decided to migrate Apex test from Xunit to MSTest.
1.Change Apex test from Xunit to MSTest:
Theory->TestMethod,InlineData->DataRow,Skip->Ignore, etc.Timeoutattribute for each Apex testsITestLoggerand follow the suggestions in the wiki.In the recent 11 runs, the Apex tests passed 8 times.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation