Reduce number of Dataflow updates through dependency tree code #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provision of transitive dependency tree nodes uses Dataflow to propagate project data from producer to consumer. This change converts a TransformBlock into a TransformManyBlock, such that we can return zero items when there's no real change to propagate. This reduces the work done by consumers, who were previously wasting resources in response to such no-op updates.
nkolev92
previously approved these changes
Nov 17, 2023
nkolev92
added
Approved for CI
Community
|
I forgot you have permissions :D |
donnie-msft
previously approved these changes
Nov 17, 2023
...ients/NuGet.VisualStudio.Implementation/SolutionExplorer/AssetsFileDependenciesDataSource.cs
Outdated
Show resolved
Hide resolved
…plorer/AssetsFileDependenciesDataSource.cs Co-authored-by: Donnie Goodson <[email protected]>
drewnoakes
dismissed stale reviews from donnie-msft and nkolev92
via
3dc5b39
donnie-msft
approved these changes
Nov 17, 2023
|
/azp run |
|
No pipelines are associated with this pull request. |
Nigusu-Allehu
pushed a commit
that referenced
this pull request
Nov 21, 2023
The provision of transitive dependency tree nodes uses Dataflow to propagate project data from producer to consumer. This change converts a `TransformBlock` into a `TransformManyBlock`, such that we can return zero items when there's no real change to propagate. This reduces the work done by consumers, who were previously wasting resources in response to such no-op updates.
drewnoakes
added a commit
that referenced
this pull request
Jul 12, 2024
This replaces the approach taken in #5508 in a way that doesn't interfere with Solution Explorer search.
Merged
3 tasks
drewnoakes
added a commit
that referenced
this pull request
Jul 13, 2024
… of dependencies tree (#5917) * Revert "Reduce number of Dataflow updates through dependency tree code (#5508)" This reverts commit d85c6ea. Turns out that the search provider uses `GetLatestVersionAsync` on this data source, meaning it must propagate a value for every input version. I will fix the original issue in a different way, by updating the consumer to ignore version-only changes instead. * Avoid tree updates when the value is unchanged This replaces the approach taken in #5508 in a way that doesn't interfere with Solution Explorer search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provision of transitive dependency tree nodes uses Dataflow to propagate project data from producer to consumer.
This change converts a TransformBlock into a TransformManyBlock, such that we can return zero items when there's no real change to propagate. This reduces the work done by consumers, who were previously wasting resources in response to such no-op updates.
Bug
Fixes: NuGet/Home#13019
Regression? Last working version: N/A
Description
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation