Unroll Linq usage in FilterDependencyProvidersForLibrary #5535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
nkolev92
reviewed
Dec 7, 2023
src/NuGet.Core/NuGet.DependencyResolver.Core/Remote/RemoteWalkContext.cs
Show resolved
Hide resolved
nkolev92
approved these changes
Dec 8, 2023
zivkan
approved these changes
Dec 11, 2023
jeffkl
approved these changes
Dec 12, 2023
kartheekp-ms
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Related: NuGet/Home#12748
Regression? Last working version:
Description
There are some easily avoidable allocations that were happening in
FilterDependencyProvidersForLibrarydue to closure and delegate allocations caused by Linq usage. I swapped the implementation and added a comment.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation