Use string.Contains instead of IEnumerable.Contains

[Erarndt]

Bug

Fixes: NuGet/Home#13124

Regression? Last working version:

Description

This code was mistakenly using the Enumerable.Contains() overload which ends up allocating an enumerator. Using string.Contains() avoids this allocation and is faster. Example benchmark over 100 invocations:

Method	Count	Mean	Error	StdDev	Gen0	Allocated
Enumerable.Contains	100	29.830 us	0.0658 us	0.0583 us	0.3662	2003 B
string.Contains	100	5.516 us	0.0105 us	0.0082 us	-	-

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[nkolev92]

Does this have the same problem?

[Erarndt]

Additional overloads for string.Contains were added in 2.1+, so this call doesn't have the same issue.

[nkolev92]

@Erarndt I think we'd probably want more granular issues here, since there's some changes that aren't related to what the main issue is claiming.

[Erarndt]

@Erarndt I think we'd probably want more granular issues here, since there's some changes that aren't related to what the main issue is claiming.

Sure, I defer to you folks on how to organize these. I've found these while investigating the main issue, so I was unsure how you'd like to categorize them.

[ghost]

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.