Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergedotnet package search to dev #5580

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

Nigusu-Allehu
Copy link
Contributor

@Nigusu-Allehu Nigusu-Allehu commented Jan 9, 2024

Bug

Fixes: NuGet/Home#6060
Fixes: NuGet/Home#5138
Fixes: NuGet/Home#12978
FIxes: NuGet/Home#13031

Regression? Last working version:

Description

PR Checklist

This feature branch PR includes three PRs that were used to add dotnet package search to NuGet.CommandLine.XPlat.

* Add three options

* Use id instead of PackageID

* Remove Some Strings

* use System.text.json

* Add erros to JSON output

* Add Format enum

* Add problems section

* Clean up tests

* Clean up

* Improve parser error handling
@Nigusu-Allehu Nigusu-Allehu requested a review from a team as a code owner January 9, 2024 15:32
@Nigusu-Allehu Nigusu-Allehu changed the title Add dotnet package search to NuGet.CommandLine.XPlat Mergedotnet package search todev Jan 9, 2024
@Nigusu-Allehu Nigusu-Allehu marked this pull request as draft January 9, 2024 15:40
@Nigusu-Allehu Nigusu-Allehu changed the title Mergedotnet package search todev Mergedotnet package search to dev Jan 9, 2024
@nkolev92
Copy link
Member

nkolev92 commented Jan 9, 2024

Can we please make sure the commit names for the 6.9.x and dev branches are the same?
Normally the process is, merge PR to dev and then cherry-pick to 6.9.x, and the release tools can detect that, but right now we have 2 PRs to 2 different branches.

cc @martinrrm

@martinrrm martinrrm marked this pull request as ready for review January 9, 2024 18:07
@jeffkl jeffkl merged commit 51986ef into dev Jan 9, 2024
16 checks passed
@jeffkl jeffkl deleted the dev-feature-migrate-systemcommandline branch January 9, 2024 18:09
martinrrm pushed a commit that referenced this pull request Jan 9, 2024
martinrrm added a commit that referenced this pull request Jan 9, 2024
Co-authored-by: Nigusu Solomon Yenework <[email protected]>
@martinrrm martinrrm restored the dev-feature-migrate-systemcommandline branch January 9, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants