Reduces some CPU time usage in SetCentralDependencies #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issues 13182 and 13183 to set a comparer and avoid allocating a new version string in SetCentralDependencies method
…genellem-msft-setCentralDependenciesComparer
Updating test to reflect change in how the dgspec centralpackageversions is written.
ghost
added
the
jeffkl
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
NuGet/Home#13182
NuGet/Home#13183
Regression? Last working version:
Description
Utilize a set string comparer to reduce CPU time when sorting in method SetCentralDependencies.
Also write out original string for central dependencies, when available, instead of creating a new string of the normalized version.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation