Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs to read auditSources from nuget.config files #5620

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Feb 2, 2024

Bug

Fixes: NuGet/Home#13211

Regression? no

Description

  • Make ConfigurationDefaults be able to load audit sources from NuGetDefaults.config
  • Add LoadAuditSources() to IPackageSourceProvider and PackageSourceProvider`
  • #nullable enable in several files
  • Fix a bunch of tests that fail when your machine has a NuGetDefaults.config with at least one package source defined. Tests should not depend on machine state.

The only functionality proposed at the moment is to read the config, not to add/modify/delete auditSources, so no APIs have been added for those actions yet.

PR Checklist

@zivkan zivkan requested a review from a team as a code owner February 2, 2024 01:08
@zivkan zivkan merged commit f45ff31 into dev Feb 6, 2024
16 checks passed
@zivkan zivkan deleted the dev-zivkan-NuGetAudit-auditSources-config branch February 6, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read auditSources from nuget.config files
3 participants