Consolidate packages.config restore implementations by minimizing discrepancies #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
reviewed
Feb 12, 2024
Co-authored-by: Jeff Kluge <[email protected]>
jeffkl
previously approved these changes
Feb 12, 2024
Co-authored-by: Jeff Kluge <[email protected]>
nkolev92
deleted the
dev-nkolev92-consolidateRestoreImplementationsByMinimizingDiscrepancies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13233
Regression? Last working version:
Description
Unfortunately we have 3 different implementations of packages.config restore.
A lot of that is due to the difference in reading the packages and part of it is not wanting to make public APIs for PC restore.
Those 3 implementations are:
There's a bunch of differences in how the PackageRestoreManager gets called. It's made my work for PC restore vulnerability checking challenging, because the calls are not unified.
The change here is primarily 1, always create a PackageRestoreData list with all packages rather than just the missing ones. The same amount of work is being done, the difference being that now we have PackageRestoreData list with all the data, which I can later use for vulnerability checking.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation