All calls to SourceRepository.GetResource must pass a cancellation token

build/BannedSymbols.txt

@@ -18,3 +18,6 @@ M:Microsoft.VisualStudio.Shell.IAsyncServiceProvider.GetServiceAsync(System.Type
 M:Microsoft.VisualStudio.Shell.AsyncPackage.GetServiceAsync(System.Type); Do not retrieve services from AsyncPackage, use the Async Service provider instead, which that class implements. Use the Microsoft.VisualStudio.Shell.ServiceExtensions.GetServiceAsync for services that have UI thread affinity or that you don't know about their affinity, and use NuGet.VisualStudio.ServiceProviderExtensions.GetFreeThreadedServiceAsync<TService, TInterface> for free threaded services.
 
 M:System.IO.Path.GetTempPath(); Use NuGetEnvironment.GetFolderPath(NuGetFolderPath.Temp)
+
+M:NuGet.Protocol.Core.Types.SourceRepository.GetResource`1(); Pass a cancellation token
+M:NuGet.Protocol.Core.Types.SourceRepository.GetResourceAsync`1(); Pass a cancellation token

src/NuGet.Clients/NuGet.CommandLine/Commands/ProjectFactory.cs

@@ -1084,7 +1084,7 @@ private void AddDependencies(Dictionary<string, Tuple<PackageReaderBase, Packagi
             var findLocalPackagesResource = Repository
                 .Factory
                 .GetCoreV3(packagesFolderPath)
-                .GetResource<FindLocalPackagesResource>();
+                .GetResource<FindLocalPackagesResource>(CancellationToken.None);
 
             // Collect all packages
             IDictionary<PackageIdentity, PackageReference> packageReferences =

src/NuGet.Clients/NuGet.CommandLine/Commands/SearchCommand.cs

@@ -70,7 +70,7 @@ public override async Task ExecuteCommandAsync()
             foreach (PackageSource source in listEndpoints)
             {
                 SourceRepository repository = Repository.Factory.GetCoreV3(source);
-                PackageSearchResource resource = await repository.GetResourceAsync<PackageSearchResource>();
+                PackageSearchResource resource = await repository.GetResourceAsync<PackageSearchResource>(cancellationToken);
 
                 if (resource is null)
                 {

src/NuGet.Clients/NuGet.PackageManagement.PowerShellCmdlets/NuGetPowerShellBaseCommand.cs

@@ -384,7 +384,6 @@ private SourceRepository CreateRepositoryFromSource(string source)
         {
             var packageSource = new PackageSource(source);
             var repository = _sourceRepositoryProvider.CreateRepository(packageSource);
-            var resource = repository.GetResource<PackageSearchResource>();
 
             return repository;
         }

src/NuGet.Clients/NuGet.PackageManagement.PowerShellCmdlets/Utils/InstalledPackageEnumerator.cs

@@ -233,7 +233,7 @@ private async Task OrderPackagesForPackagesConfigAsync(
 
             var dependencyInfoResource = await packageManager
                 .PackagesFolderSourceRepository
-                .GetResourceAsync<DependencyInfoResource>();
+                .GetResourceAsync<DependencyInfoResource>(token);
 
             using (var sourceCacheContext = new SourceCacheContext())
             {

src/NuGet.Clients/NuGet.PackageManagement.UI/Actions/UIActionEngine.cs

@@ -1186,7 +1186,7 @@ private static async Task<IPackageSearchMetadata[]> GetPackageMetadataThrottledA
 
             foreach (var source in sources)
             {
-                var metadataResource = source.GetResource<PackageMetadataResource>();
+                var metadataResource = source.GetResource<PackageMetadataResource>(token);
                 if (metadataResource == null)
                 {
                     continue;

src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/PackageReferenceCommands/AddPackageReferenceCommandRunner.cs

@@ -263,7 +263,7 @@ public static async Task<NuGetVersion> GetLatestVersionAsync(PackageSpec origina
         {
             IList<PackageSource> sources = AddPackageCommandUtility.EvaluateSources(originalPackageSpec.RestoreMetadata.Sources, originalPackageSpec.RestoreMetadata.ConfigFilePaths);
 
-            return await AddPackageCommandUtility.GetLatestVersionFromSourcesAsync(sources, logger, packageId, prerelease);
+            return await AddPackageCommandUtility.GetLatestVersionFromSourcesAsync(sources, logger, packageId, prerelease, CancellationToken.None);
         }
 
         private static LibraryDependency GenerateLibraryDependency(

src/NuGet.Core/NuGet.CommandLine.XPlat/Utility/AddPackageCommandUtility.cs

@@ -25,15 +25,15 @@ internal static class AddPackageCommandUtility
         /// <param name="prerelease">Whether to include prerelease versions</param>
         /// <returns>Return the latest version available from multiple sources and if no version is found returns null.</returns>
 
-        public static async Task<NuGetVersion> GetLatestVersionFromSourcesAsync(IList<PackageSource> sources, ILogger logger, string packageId, bool prerelease)
+        public static async Task<NuGetVersion> GetLatestVersionFromSourcesAsync(IList<PackageSource> sources, ILogger logger, string packageId, bool prerelease, CancellationToken cancellationToken)
         {
             var maxTasks = Environment.ProcessorCount;
             var tasks = new List<Task<NuGetVersion>>();
             var latestReleaseList = new List<NuGetVersion>();
 
             foreach (var source in sources)
             {
-                tasks.Add(Task.Run(() => GetLatestVersionFromSourceAsync(source, logger, packageId, prerelease)));
+                tasks.Add(Task.Run(() => GetLatestVersionFromSourceAsync(source, logger, packageId, prerelease, cancellationToken)));
                 if (maxTasks <= tasks.Count)
                 {
                     var finishedTask = await Task.WhenAny(tasks);
@@ -64,10 +64,10 @@ public static async Task<NuGetVersion> GetLatestVersionFromSourcesAsync(IList<Pa
         /// <param name="packageId">Package to look for</param>
         /// <param name="prerelease">Whether to include prerelease versions</param>
         /// <returns>Returns the latest version available from a source or a null if non is found.</returns>
-        public static async Task<NuGetVersion> GetLatestVersionFromSourceAsync(PackageSource source, ILogger logger, string packageId, bool prerelease)
+        public static async Task<NuGetVersion> GetLatestVersionFromSourceAsync(PackageSource source, ILogger logger, string packageId, bool prerelease, CancellationToken cancellationToken)
         {
             SourceRepository repository = Repository.Factory.GetCoreV3(source);
-            PackageMetadataResource resource = await repository.GetResourceAsync<PackageMetadataResource>();
+            PackageMetadataResource resource = await repository.GetResourceAsync<PackageMetadataResource>(cancellationToken);
 
             using (var cache = new SourceCacheContext())
             {

src/NuGet.Core/NuGet.Commands/CommandRunners/DeleteRunner.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Globalization;
+using System.Threading;
 using System.Threading.Tasks;
 using NuGet.Common;
 using NuGet.Configuration;
@@ -34,7 +35,7 @@ public static async Task Run(
             {
                 logger.LogWarning(string.Format(CultureInfo.CurrentCulture, Strings.Warning_HttpServerUsage, "delete", packageSource.Source));
             }
-            var packageUpdateResource = await CommandRunnerUtility.GetPackageUpdateResource(sourceProvider, packageSource);
+            var packageUpdateResource = await CommandRunnerUtility.GetPackageUpdateResource(sourceProvider, packageSource, CancellationToken.None);
 
             await packageUpdateResource.Delete(
                 packageId,

src/NuGet.Core/NuGet.Commands/CommandRunners/PushRunner.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Globalization;
+using System.Threading;
 using System.Threading.Tasks;
 using NuGet.Common;
 using NuGet.Configuration;
@@ -39,7 +40,7 @@ public static async Task Run(
                 timeoutSeconds = 5 * 60;
             }
             PackageSource packageSource = CommandRunnerUtility.GetOrCreatePackageSource(sourceProvider, source);
-            var packageUpdateResource = await CommandRunnerUtility.GetPackageUpdateResource(sourceProvider, packageSource);
+            var packageUpdateResource = await CommandRunnerUtility.GetPackageUpdateResource(sourceProvider, packageSource, CancellationToken.None);
 
             // Only warn for V3 style sources because they have a service index which is different from the final push url.
             if (packageSource.IsHttp && !packageSource.IsHttps && !packageSource.AllowInsecureConnections &&
@@ -58,7 +59,7 @@ public static async Task Run(
                 && !sourceUri.IsFile
                 && sourceUri.IsAbsoluteUri)
             {
-                symbolPackageUpdateResource = await CommandRunnerUtility.GetSymbolPackageUpdateResource(sourceProvider, source);
+                symbolPackageUpdateResource = await CommandRunnerUtility.GetSymbolPackageUpdateResource(sourceProvider, source, CancellationToken.None);
                 if (symbolPackageUpdateResource != null)
                 {
                     symbolSource = symbolPackageUpdateResource.SourceUri.AbsoluteUri;

src/NuGet.Core/NuGet.Commands/RestoreCommand/SourceRepositoryDependencyProvider.cs

@@ -257,7 +257,7 @@ private async Task<LibraryIdentity> FindLibraryCoreAsync(
             ILogger logger,
             CancellationToken cancellationToken)
         {
-            await EnsureResource();
+            await EnsureResource(cancellationToken);
 
             if (libraryRange.VersionRange?.MinVersion != null && libraryRange.VersionRange.IsMinInclusive && !libraryRange.VersionRange.IsFloating)
             {
@@ -400,7 +400,7 @@ private async Task<LibraryDependencyInfo> GetDependenciesCoreAsync(
             FindPackageByIdDependencyInfo packageInfo = null;
             try
             {
-                await EnsureResource();
+                await EnsureResource(cancellationToken);
 
                 if (_throttle != null)
                 {
@@ -494,7 +494,7 @@ public async Task<IPackageDownloader> GetPackageDownloaderAsync(
 
             try
             {
-                await EnsureResource();
+                await EnsureResource(cancellationToken);
 
                 if (_throttle != null)
                 {
@@ -604,11 +604,11 @@ private static NuGetFramework DeconstructFallbackFrameworks(NuGetFramework nuGet
             return nuGetFramework;
         }
 
-        private async Task EnsureResource()
+        private async Task EnsureResource(CancellationToken cancellationToken)
         {
             if (_findPackagesByIdResource == null)
             {
-                var resource = await _sourceRepository.GetResourceAsync<FindPackageByIdResource>();
+                var resource = await _sourceRepository.GetResourceAsync<FindPackageByIdResource>(cancellationToken);
 
                 lock (_lock)
                 {

src/NuGet.Core/NuGet.Commands/Utility/CommandRunnerUtility.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Linq;
+using System.Threading;
 using System.Threading.Tasks;
 using NuGet.Common;
 using NuGet.Configuration;
@@ -68,12 +69,12 @@ public static string GetApiKey(ISettings settings, string endpoint, string sourc
             return apiKey;
         }
 
-        public static async Task<PackageUpdateResource> GetPackageUpdateResource(IPackageSourceProvider sourceProvider, PackageSource packageSource)
+        public static async Task<PackageUpdateResource> GetPackageUpdateResource(IPackageSourceProvider sourceProvider, PackageSource packageSource, CancellationToken cancellationToken)
         {
             var sourceRepositoryProvider = new CachingSourceProvider(sourceProvider);
             var sourceRepository = sourceRepositoryProvider.CreateRepository(packageSource);
 
-            return await sourceRepository.GetResourceAsync<PackageUpdateResource>();
+            return await sourceRepository.GetResourceAsync<PackageUpdateResource>(cancellationToken);
         }
 
         public static PackageSource GetOrCreatePackageSource(IPackageSourceProvider sourceProvider, string source)
@@ -97,7 +98,7 @@ public static PackageSource GetOrCreatePackageSource(IPackageSourceProvider sour
             return packageSource;
         }
 
-        public static async Task<SymbolPackageUpdateResourceV3> GetSymbolPackageUpdateResource(IPackageSourceProvider sourceProvider, string source)
+        public static async Task<SymbolPackageUpdateResourceV3> GetSymbolPackageUpdateResource(IPackageSourceProvider sourceProvider, string source, CancellationToken cancellationToken)
         {
             // Use a loaded PackageSource if possible since it contains credential info
             var packageSource = sourceProvider.LoadPackageSources()
@@ -112,7 +113,7 @@ public static async Task<SymbolPackageUpdateResourceV3> GetSymbolPackageUpdateRe
             var sourceRepositoryProvider = new CachingSourceProvider(sourceProvider);
             var sourceRepository = sourceRepositoryProvider.CreateRepository(packageSource);
 
-            return await sourceRepository.GetResourceAsync<SymbolPackageUpdateResourceV3>();
+            return await sourceRepository.GetResourceAsync<SymbolPackageUpdateResourceV3>(cancellationToken);
         }
     }
 }

src/NuGet.Core/NuGet.PackageManagement/NuGetPackageManager.cs

@@ -1352,7 +1352,7 @@ public async Task<IEnumerable<PackageDependencyInfo>> GetInstalledPackagesDepend
             {
                 var targetFramework = nuGetProject.GetMetadata<NuGetFramework>(NuGetProjectMetadataKeys.TargetFramework);
                 var installedPackageIdentities = (await nuGetProject.GetInstalledPackagesAsync(token)).Select(pr => pr.PackageIdentity);
-                return await GetDependencyInfoFromPackagesFolderAsync(installedPackageIdentities, targetFramework, includeUnresolved);
+                return await GetDependencyInfoFromPackagesFolderAsync(installedPackageIdentities, targetFramework, includeUnresolved, token);
             }
             else
             {
@@ -1371,7 +1371,9 @@ public async Task<IEnumerable<PackageIdentity>> GetInstalledPackagesInDependency
             var installedPackages = await nuGetProject.GetInstalledPackagesAsync(token);
             var installedPackageIdentities = installedPackages.Select(pr => pr.PackageIdentity);
             var dependencyInfoFromPackagesFolder = await GetDependencyInfoFromPackagesFolderAsync(installedPackageIdentities,
-                targetFramework);
+                targetFramework,
+                includeUnresolved: false,
+                token);
 
             // dependencyInfoFromPackagesFolder can be null when NuGetProtocolException is thrown
             var resolverPackages = dependencyInfoFromPackagesFolder?.Select(package =>
@@ -2022,7 +2024,7 @@ await PreviewBuildIntegratedProjectActionsAsync(buildIntegratedProject, actions,
             else
             {
                 var logger = new ProjectContextLogger(nuGetProjectContext);
-                var sourceRepository = await GetSourceRepository(packageIdentity, effectiveSources, resolutionContext.SourceCacheContext, logger);
+                var sourceRepository = await GetSourceRepository(packageIdentity, effectiveSources, resolutionContext.SourceCacheContext, logger, token);
                 nuGetProjectActions.Add(NuGetProjectAction.CreateInstallProjectAction(packageIdentity, sourceRepository, nuGetProject));
             }
 
@@ -2049,7 +2051,8 @@ await PreviewBuildIntegratedProjectActionsAsync(buildIntegratedProject, actions,
         private static async Task<SourceRepository> GetSourceRepository(PackageIdentity packageIdentity,
             IEnumerable<SourceRepository> sourceRepositories,
             SourceCacheContext sourceCacheContext,
-            ILogger logger)
+            ILogger logger,
+            CancellationToken cancellationToken)
         {
             SourceRepository source = null;
 
@@ -2063,7 +2066,7 @@ private static async Task<SourceRepository> GetSourceRepository(PackageIdentity
             foreach (var sourceRepository in sourceRepositories)
             {
                 // TODO: fetch the resource in parallel also
-                var metadataResource = await sourceRepository.GetResourceAsync<MetadataResource>();
+                var metadataResource = await sourceRepository.GetResourceAsync<MetadataResource>(cancellationToken);
                 if (metadataResource != null)
                 {
                     var task = Task.Run(() => metadataResource.Exists(packageIdentity, sourceCacheContext, logger, tokenSource.Token), tokenSource.Token);
@@ -2376,7 +2379,9 @@ await PreviewBuildIntegratedProjectActionsAsync(buildIntegratedProject, actions,
             var log = new LoggerAdapter(nuGetProjectContext);
             var installedPackageIdentities = (await nuGetProject.GetInstalledPackagesAsync(token)).Select(pr => pr.PackageIdentity);
             var dependencyInfoFromPackagesFolder = await GetDependencyInfoFromPackagesFolderAsync(installedPackageIdentities,
-                packageReferenceTargetFramework);
+                packageReferenceTargetFramework,
+                includeUnresolved: false,
+                token);
 
             nuGetProjectContext.Log(ProjectManagement.MessageLevel.Info, Strings.ResolvingActionsToUninstallPackage, packageIdentity);
             // Step-2 : Determine if the package can be uninstalled based on the metadata resources
@@ -2392,10 +2397,11 @@ await PreviewBuildIntegratedProjectActionsAsync(buildIntegratedProject, actions,
 
         private async Task<IEnumerable<PackageDependencyInfo>> GetDependencyInfoFromPackagesFolderAsync(IEnumerable<PackageIdentity> packageIdentities,
             NuGetFramework nuGetFramework,
-            bool includeUnresolved = false)
+            bool includeUnresolved,
+            CancellationToken cancellationToken)
         {
-            var dependencyInfoResource = await PackagesFolderSourceRepository.GetResourceAsync<DependencyInfoResource>();
-            return await PackageGraphAnalysisUtilities.GetDependencyInfoForPackageIdentitiesAsync(packageIdentities, nuGetFramework, dependencyInfoResource, NullSourceCacheContext.Instance, includeUnresolved, NullLogger.Instance, CancellationToken.None);
+            var dependencyInfoResource = await PackagesFolderSourceRepository.GetResourceAsync<DependencyInfoResource>(cancellationToken);
+            return await PackageGraphAnalysisUtilities.GetDependencyInfoForPackageIdentitiesAsync(packageIdentities, nuGetFramework, dependencyInfoResource, NullSourceCacheContext.Instance, includeUnresolved, NullLogger.Instance, cancellationToken);
         }
 
         /// <summary>
@@ -3886,7 +3892,7 @@ private static async Task<ResolvedPackage> GetLatestVersionCoreAsync(
             Common.ILogger log,
             CancellationToken token)
         {
-            var dependencyInfoResource = await source.GetResourceAsync<DependencyInfoResource>();
+            var dependencyInfoResource = await source.GetResourceAsync<DependencyInfoResource>(token);
 
             // Resolve the package for the project framework and cache the results in the
             // resolution context for the gather to use during the next step.

src/NuGet.Core/NuGet.Protocol/HttpSource/HttpSource.cs

@@ -435,7 +435,7 @@ public static HttpSource Create(SourceRepository source, IThrottle throttle)
                 throw new ArgumentNullException(nameof(throttle));
             }
 
-            Func<Task<HttpHandlerResource>> factory = () => source.GetResourceAsync<HttpHandlerResource>();
+            Func<Task<HttpHandlerResource>> factory = () => source.GetResourceAsync<HttpHandlerResource>(CancellationToken.None);
 
             return new HttpSource(source.PackageSource, factory, throttle);
         }

src/NuGet.Core/NuGet.Protocol/Providers/PackageMetadataResourceV3Provider.cs

@@ -22,9 +22,9 @@ public override async Task<Tuple<bool, INuGetResource>> TryCreate(SourceReposito
 
             if (await source.GetResourceAsync<ServiceIndexResourceV3>(token) != null)
             {
-                var regResource = await source.GetResourceAsync<RegistrationResourceV3>();
-                var reportAbuseResource = await source.GetResourceAsync<ReportAbuseResourceV3>();
-                var packageDetailsUriResource = await source.GetResourceAsync<PackageDetailsUriResourceV3>();
+                var regResource = await source.GetResourceAsync<RegistrationResourceV3>(token);
+                var reportAbuseResource = await source.GetResourceAsync<ReportAbuseResourceV3>(token);
+                var packageDetailsUriResource = await source.GetResourceAsync<PackageDetailsUriResourceV3>(token);
 
                 var httpSourceResource = await source.GetResourceAsync<HttpSourceResource>(token);
 

src/NuGet.Core/NuGet.Protocol/Providers/RawSearchResourceV3Provider.cs

@@ -21,7 +21,7 @@ public RawSearchResourceV3Provider()
         public override async Task<Tuple<bool, INuGetResource>> TryCreate(SourceRepository source, CancellationToken token)
         {
             RawSearchResourceV3 curResource = null;
-            var serviceIndex = await source.GetResourceAsync<ServiceIndexResourceV3>();
+            var serviceIndex = await source.GetResourceAsync<ServiceIndexResourceV3>(token);
 
             if (serviceIndex != null)
             {