Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
dotnet nuget why
command #5761Add
dotnet nuget why
command #5761Changes from 45 commits
708f4e2
10245f8
2098b79
3d428bc
db9a7ce
ef25ca2
9170c26
b1b74f5
067430a
08e95fc
ae50998
3f153f9
8a750f1
25804a8
a44299b
073e9b5
7ed373a
aaee328
ebc4732
4a42f3e
d9a6482
904740e
69bfb3b
cb0c043
e55583a
7891af4
fa67ec9
961b7df
cf5771f
efaee79
0bba3a1
8ee8eba
31a6bf3
5c3ad52
852edf0
923a1df
527d448
506ee92
1297105
fec9de8
b164b31
2a1c576
dccf34c
50394da
8f3db89
d9c8890
6074b25
7aceac8
8aff030
ee68859
118735d
7b9a2e9
4a60b13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Just wondering why the namespace is different to the project's default namespace + directory structure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All commands and files in this project fall in the
NuGet.CommandLine.XPlat
namespace, so I've removed other namespaces likeNuGet.CommandLine.XPlat.WhyCommandUtility
and moved everything underNuGet.CommandLine.XPlat
to keep things consistent. Let me know if you think this needs changes or can be improved uponThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the reasons to organize code on the filesystem is identical to the reasons to organize code in namespaces. Therefore, I consider it bad when they're out of sync. But I recognise that NuGet's existing code does this. I just think it's a bad pattern that we should stop copying. But I'm not going to hold up this PR because of this, and I don't know if anyone else in the team share my opinion. But for what it's worth, since this file's class is internal, there's no public API risk of moving it to a "more appropriate" namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that MSBuild only returns project files which exist. @jeffkl would know for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can enhance the MSBuildAPIUtility to just return the ProjectAndSolution type instead of selecting only the paths in
GetProjectsFromSolution
. That way, you wouldn't need convert the paths back to projects, here.I'm not familiar with these types, so let's see if @jeffkl has opinions on this.