LibraryRange.ToLockFileDependencyGroupString handles scenarios without a specified version gracefully #5900
+26
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
changed the title
nkolev92
changed the title
Nigusu-Allehu
approved these changes
Jul 2, 2024
jeffkl
approved these changes
Jul 2, 2024
zivkan
approved these changes
Jul 3, 2024
zivkan
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13563
Regression? Last working version:
Description
2be8680 accidentally regressed the writing for ToLockFileDependencyGroupString, where a package is missing a version.
It used to just write the name, but it was accidentally changed to write null, which led to NuGet/Home#13563, and a null reference on the .NET SDK side.
There's probably still some improvements to do on the SDK side, but the NuGet side itself is a regression.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation