Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullability declarations to ResolverUtility and RemoteWalkContext #5909

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Jul 9, 2024

Bug

Fixes: NuGet/Home#13617

Regression? Last working version:

Description

I was digging into this code for a feature and I thought it'd be doable to add nullability annotations.
It also minimizes the amount of references we see for that class.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception - Plenty of existing tests.
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@nkolev92 nkolev92 force-pushed the dev-nkolev92-cleanupResolverUtility branch from f2aa77c to 1dd9010 Compare July 10, 2024 19:20
@nkolev92 nkolev92 marked this pull request as ready for review July 10, 2024 23:13
@nkolev92 nkolev92 requested a review from a team as a code owner July 10, 2024 23:13
@nkolev92 nkolev92 merged commit 468c95b into dev Jul 11, 2024
27 of 29 checks passed
@nkolev92 nkolev92 deleted the dev-nkolev92-cleanupResolverUtility branch July 11, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nullability declarations to ResolverUtility and RemoteWalkContext
3 participants