Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always debug RestoreTask and RestoreEx when environment variable is set #6008

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Always debug RestoreTask and RestoreEx when environment variable is set #6008

merged 3 commits into from
Sep 9, 2024

Conversation

KirillOsenkov
Copy link
Contributor

Bug

Fixes:

Description

Allows to debug RestoreEx task for production builds of NuGet

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@KirillOsenkov KirillOsenkov requested a review from a team as a code owner September 4, 2024 00:12
@dotnet-policy-service dotnet-policy-service bot added the Community PRs created by someone not in the NuGet team label Sep 4, 2024
@KirillOsenkov KirillOsenkov changed the title Always debug RestoreEx when environment variable is set Always debug RestoreTask and RestoreEx when environment variable is set Sep 7, 2024
@jeffkl jeffkl self-assigned this Sep 8, 2024
@jeffkl
Copy link
Contributor

jeffkl commented Sep 9, 2024

People should be aware that the DEBUG_RESTORE_TASK is better when debugging static graph-based restore and DEBUG_RESTORE_TASK_EX is really only for debugging the task. Since static graph-based restore runs out-of-proc, the latter won't help you debug the functionality.

@jeffkl jeffkl enabled auto-merge (squash) September 9, 2024 21:48
@jeffkl jeffkl merged commit cd1e75e into NuGet:dev Sep 9, 2024
28 checks passed
@jeffkl jeffkl mentioned this pull request Sep 9, 2024
Merged
3 tasks
@KirillOsenkov KirillOsenkov deleted the kirillo/debug-restoreex branch September 10, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkl jeffkl jeffkl approved these changes

Assignees

@jeffkl jeffkl

Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KirillOsenkov @jeffkl