Parse .NET Core project.json version strings as VersionRange #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NuGet/Home#3070 and NuGet/Home#3095.
In a project.json you can specify a dependency with a version range, e.g. a floating version like
1.0.0-*
. The problem was that we were simply parsing this string as aNuGetVersion
(which is a specific version) not aVersionRange
. This problem is only occurring in .NET Core project.json projects, not UWP project.json.Right now, our UI has a limitation where it only shows a specific version (not a version range). For this reason, we will now parse this string as a version range but only display the minimum of the version range. This is not an ideal solution since it's ugly and unhelpful but we are already doing this today with UWP project.json projects. The improvement to the UI to display version ranges is tracked here: NuGet/Home#3101.
/cc @alpaix @yishaigalatzer @rohit21agrawal @mlorbetske