Allow netstandard to install contentFiles under the any tfm #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default ContentModel translates 'any' to 'dotnet', this works for the lib folder but for scenarios such as contentFiles any does refer to all frameworks. This change updates contentModel to allow per pattern token replacement tables. Fixes NuGet/Home#3118
| var collection = new ContentItemCollection(); | ||
| collection.Load(new string[] | ||
| { | ||
| "contentFiles/any/any/config1.xml", |
|
|
||
| // Assert | ||
| Assert.Equal(1, groups.Count); | ||
| Assert.Equal(".NETPlatform,Version=v5.0", groups[0].Properties["tfm"].ToString()); |
There was a problem hiding this comment.
Compare to FrameworkIdentifiers.CommonFrameworks.DotNet? This seems like a "truer" test since the string ".NETPlatform,Version=v5.0" would also allow this to pass.
There was a problem hiding this comment.
I can update that, the type here is Object, and apparently Assert.Equal(FrameworkIdentifiers.CommonFrameworks.DotNet, groups[0].Properties["tfm"]) is false, even though it is that exact framework
|
Thanks for the background information on this one. Address/ignore my last comment then |
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
any->dotnetfor contentFiles, unlike lib and other folders contentFiles does supports theanyframework.ContentModel previously defined token replacements such as
any->dotneton a per pattern basis. All patterns that contained{tfm}would apply this replacement. This change moves the replacement table to the pattern which contains the folder name to allow fine grained control over it.Fixes NuGet/Home#3118
//cc @joelverhagen @alpaix @jainaashish @rohit21agrawal @rrelyea @drewgil