Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove offensive language from our source code #1435

Closed
claycompton opened this issue Aug 14, 2013 · 4 comments
Closed

Remove offensive language from our source code #1435

claycompton opened this issue Aug 14, 2013 · 4 comments
Assignees

Comments

@claycompton
Copy link

There are a few examples of offensive or suspect language buried in our source code. We should proactively clean up our source code now to avoid the chance that one of these terms could offend future contributors.

FileLineTermContext
Facts\Services\PackageServiceFacts.cs1079damn// Nothing to assert because it's too damn complicated to test the actual LINQ expression.
Website\PackageCurators\TagBasedPackageCurator.cs 26foobar// Break the tags up so we can be sure we don't catch any partial matches (i.e. "foobar" when we're looking for "foo")
Website\Infrastructure\Lucene\LuceneSearchService.cs 283foo-bar// 3) For ID search, split search terms such as Id:"Foo.Bar" and "Foo-Bar" into a phrase "Foo Bar" which will work better for analyzed field search
Website\Infrastructure\Lucene\LuceneSearchService.cs 201foo bar// a) General search? [foo bar]
Website\Infrastructure\Lucene\LuceneSearchService.cs 202foo bar// b) Id-targeted search? [id:Foo bar]
Website\Infrastructure\Lucene\LuceneSearchService.cs 203foo bar// c) Other Field-targeted search? [author:Foo bar]
Website\Infrastructure\Lucene\LuceneSearchService.cs301foo bar// 3) For ID search, split search terms such as Id:"Foo.Bar" and "Foo-Bar" into a phrase "Foo Bar" which will work better for analyzed field search
Website\Infrastructure\Lucene\AnalysisHelper.cs23sucks// This attribute way of getting token properties sucks, but it's the non-obsolete one.
Website\Services\PackageFileService.cs78sucks// c) it sucks to hit the database just to look up the right case
Website\DataServices\SearchAdaptor.cs128hack// HACK: The way the default paging works is WCF attempts to read up to the MaxPageSize elements. If it finds as many, it'll assume there
@analogrelay
Copy link
Contributor

sigh yeah....

@NullVoxPopuli
Copy link

sounds like the code should just be improved, rather than nice-ifying the comments.

@NeLaurynas
Copy link

Here comes open source pussies with their codes of conducts AND DID YOU JUST ASSUME MY GENDER??? GITHUB IS SAFE SPACE!

Why do we, hardened enterprise developers with balls, comply with these... garbage?

@blowdart
Copy link
Member

You realise this was from 2013, right? I'm locking this, because this just isn't useful or constructive in any way.

@NuGet NuGet locked and limited conversation to collaborators Nov 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants