-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create NuGet 6.1 release notes #2667
Conversation
Docs Build status updates of commit 2be02cb: ✅ Validation status: passed
docs/release-notes/NuGet-6.1.md
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 8c7c344:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/release-notes/NuGet-6.1.md | View | Details |
docs/release-notes/NuGet-6.1.md
- Line 4, Column 9: [Warning: author-not-found - See documentation]
Invalid value for author: '<GithubAlias>' is not a valid GitHub ID.
- Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation]
Invalid value for 'ms.author', '<MicrosoftAlias>' is not a valid Microsoft alias.
- Line 16, Column 7: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'NuGetVersion' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 16, Column 71: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'VSYear' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 16, Column 88: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'VSVersion' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 16, Column 151: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'SDKVersion' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 18, Column 44: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'VSYear' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 66, Column 126: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'GetProjectReferencesAsync' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
Docs Build status updates of commit 0f9ce95: ✅ Validation status: passed
docs/release-notes/NuGet-6.1.md
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@erdembayar & @jebriede can you comment if these features should have screenshots or extended blurbs?
Can someone reviewing this PR provide a list of community contributions and I'll add a table? |
My PR has several screenshots, not sure if we need to include it. NuGet/NuGet.Client#4211 |
Docs Build status updates of commit 7d6c422: ✅ Validation status: passed
docs/release-notes/NuGet-6.1.md
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 91ce040: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor feedback.
This was definitely a bug fixing release :)
docs/release-notes/NuGet-6.1.md
Outdated
|
||
* [DCR][No Customer Impact]: NuGetPackage (VS extension entry point) should not use DTEEvents - [#11360](https://github.com/NuGet/Home/issues/11360) | ||
|
||
* [DCR]: Improve NuGet.Client build and debugging speed by making ilmerge targets use MSBuild up to date checks - [#11386](https://github.com/NuGet/Home/issues/11386) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is engineering right? Probably the tool should skip it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created NuGet/Entropy#66 to address this comment.
docs/release-notes/NuGet-6.1.md
Outdated
|
||
* [Bug]: VS package source options clears all checkboxes when adding or removing sources - [#11521](https://github.com/NuGet/Home/issues/11521) | ||
|
||
**StillOpens:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are meant to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this section in the latest commit.
docs/release-notes/NuGet-6.1.md
Outdated
|
||
**Nones:** | ||
|
||
* NuGet no longer uses CPS's JTF - [#8317](https://github.com/NuGet/Home/issues/8317) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These probably need to have a type added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am considering removing this * NuGet no longer uses CPS's JTF - [#8317](https://github.com/NuGet/Home/issues/8317)
from the release notes because the linked PR fixes NuGet/Home#8414 bug which is already added to the bugs list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as we can release as is. Would love to get community contributions included however.
docs/release-notes/NuGet-6.1.md
Outdated
|
||
* NuGet no longer uses CPS's JTF - [#8317](https://github.com/NuGet/Home/issues/8317) | ||
|
||
* [5.x] Make restore types that are project.json-specific obsolete - [#9149](https://github.com/NuGet/Home/issues/9149) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that making type obsolete falls under Type:Engineering
work. Hence removing this from the release notes.
docs/release-notes/NuGet-6.1.md
Outdated
|
||
* [5.x] Make restore types that are project.json-specific obsolete - [#9149](https://github.com/NuGet/Home/issues/9149) | ||
|
||
* [Bug]: Use IAsyncServiceProvider extension methods instead of type casting ourselves - [#11339](https://github.com/NuGet/Home/issues/11339) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this issue from the release notes because the issue has Type:Engineering
label.
docs/release-notes/NuGet-6.1.md
Outdated
|
||
* [Bug]: Use IAsyncServiceProvider extension methods instead of type casting ourselves - [#11339](https://github.com/NuGet/Home/issues/11339) | ||
|
||
* Remove NUGET_FRAMEWORKS_INTERNAL compiler constant - [#11418](https://github.com/NuGet/Home/issues/11418) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this issue from the release notes because the issue has Type:Engineering
label.
Docs Build status updates of commit 93dee3c: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 3393596: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 7f9ca6b: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@JonDouglas - I added a table for community contributions in the latest commit. Please take a look and let me know your feedback. |
Thank you @kartheekp-ms for adding that and the feedback section. All good from my side |
docs/release-notes/NuGet-6.1.md
Outdated
|
||
## Summary: What's New in 6.1 | ||
|
||
* Show help only for the error itself has to do with a command, argument, or option being invalid with `dotnet nuget` command - [#10788](https://github.com/NuGet/Home/issues/10788) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please update the issue title and the release notes so that we show what's the new behavior in the release rather than the problem? For example, 10788 would be better described as: "show subcommand help instead of main dotnet nuget trust command help for all cases."
We are already doing the above for 11091, so we only need to address this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aortiz-msft - I addressed your comment. Please review whenever you have a minute so that I can merge this PR ASAP.
Docs Build status updates of commit f689275: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit c3304c7: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 426e2fe: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
I've only run the tool, nothing more. I haven't tried to validate from the commit list that we're not missing issues, I haven't sanitised any issues, etc.