Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Semver versioning for Chocolatey packages #245

Closed
wants to merge 1 commit into from

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Nov 20, 2017

fixes #243

@304NotModified 304NotModified mentioned this pull request Nov 20, 2017
@304NotModified 304NotModified changed the title Fix buildNumberOffset Fix Semver versioning Nov 20, 2017
@304NotModified 304NotModified changed the title Fix Semver versioning Fix Semver versioning for Chocolatey packages Nov 20, 2017
@304NotModified
Copy link
Member Author

@onovotny your opinion on this please, see also #243.

I guess the version bump PR should be a without a merge commit to keep the "git height" 0

@@ -1,5 +1,6 @@
{
"version": "3.24",
"buildNumberOffset": -1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't do this for the app. You can use 3.25.0 if that's what you really want for the release and then use 3.26.0-build.{height} for subsequent builds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, guess that's #246 ?

@304NotModified 304NotModified deleted the 304NotModified-patch-2 branch November 20, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chocolatey version on AppVeyor is non-semver
2 participants