Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Handle VS 2017 projects for .NET classic #160

Merged
merged 5 commits into from
Nov 2, 2017
Merged

Handle VS 2017 projects for .NET classic #160

merged 5 commits into from
Nov 2, 2017

Conversation

skolima
Copy link
Collaborator

@skolima skolima commented Nov 1, 2017

Test uses a sample from 4.6.1 VS2017 project format, with a namespace and slightly different version storage (node instead of attribute).

@AnthonySteele
Copy link
Member

AnthonySteele commented Nov 1, 2017

There seem to be 2 things there -
An xml namespace at the root node, and that the package's Version can be an element not an attr on the PackageReference?

I see a doc saying "all metadata to be specified as a attribute or child element":
https://github.com/NuGet/Home/wiki/PackageReference-Specification
So that's correct

@skolima
Copy link
Collaborator Author

skolima commented Nov 1, 2017

Turns out the updater needs to be changed slightly as well, otherwise NuKeeper will put two versions of the dependency in.
image

@skolima skolima changed the title Parse VS 2017 projects also when namespace is present Parse VS 2017 projects for .NET classic Nov 1, 2017
@skolima
Copy link
Collaborator Author

skolima commented Nov 1, 2017

but requires a workaround for the older version
@skolima
Copy link
Collaborator Author

skolima commented Nov 1, 2017

Workaround used for dotnet add package not removing old version every time: run dotnet remove package first.

@skolima skolima requested a review from AnthonySteele November 1, 2017 17:47
@skolima skolima changed the title Parse VS 2017 projects for .NET classic Handle VS 2017 projects for .NET classic Nov 1, 2017
@skolima skolima merged commit c19a52f into NuKeeperDotNet:master Nov 2, 2017
@skolima skolima deleted the vs17-full-framework branch November 2, 2017 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants