gcc 14.2.1 flags calloc error and aborts #996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calloc(sizeof(foo), count) since the definition of calloc calls for the count argument to be first and the datawidget argument to be second. Like it or not, the diffence causes gcc to error-out. This change makes it possible to build under Fedora 40 and later.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(from the commit comment)
gcc 14.2.1, shipping with fedora 40, complains about
calloc(sizeof(foo), count)since the definition of calloc calls for the count argument to be first and the datawidget argument to be second. Like it or not, the difference causes gcc to error-out.
This change makes it possible to build under Fedora 40 and later.
I am unable to test this at runtime, so this change should be viewed with caution. But the modification should be benign to less finicky compilers, and is necessary for gcc 14.2.1 (and likely, beyond).