Skip to content

Commit

Permalink
fix: @ember/test-waiters must be a peer dependency
Browse files Browse the repository at this point in the history
See explanation: #403 (comment)
tldr: peerDeps are the only way to guarantee that modern packagers
only load one version (specified by the consumer)
  • Loading branch information
NullVoxPopuli committed Feb 23, 2022
1 parent 1101409 commit 01866c7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ember-resources/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
},
"dependencies": {
"@embroider/addon-shim": "^1.2.0",
"@embroider/macros": "^1.2.0",
"@embroider/macros": "^1.2.0"
},
"peerDependencies": {
"@ember/test-waiters": "^3.0.0"
},
"devDependencies": {
Expand Down

0 comments on commit 01866c7

Please sign in to comment.