Fix issue where, in some situations, the immediate-invoker helper manager (used when you use resourceFactory) was not correctly destroying the previous instance of a resource (such as when args change))
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Estimated impact to a consuming app, depending on which bundle is imported
|
NullVoxPopuli
changed the title
resourceFactory) was not correctly destroying the previous instance of a resource (such as when args change))
NullVoxPopuli
changed the title
resourceFactory) was not correctly destroying the previous instance of a resource (such as when args change))resourceFactory) was not correctly destroying the previous instance of a resource (such as when args change))
NullVoxPopuli
commented
Jun 18, 2024
| @@ -14,9 +14,6 @@ type ResourceFactory<Value = any, Args = any> = (...args: SpreadFor<Args>) => Va | |||
|
|
|||
| interface State { | |||
| cache: ReturnType<typeof invokeHelper>; | |||
| fn: any; | |||
There was a problem hiding this comment.
These were all unused
NullVoxPopuli
commented
Jun 18, 2024
| let result = invokeHelper(cache, resource); | ||
|
|
||
| if (previous) { | ||
| destroy(previous); |
NullVoxPopuli
commented
Jun 18, 2024
| @@ -72,6 +78,9 @@ class ResourceInvokerManager { | |||
| } | |||
|
|
|||
| getDestroyable({ cache }: State) { | |||
| /** | |||
| * This is the parent cache, from `createHelper` | |||
There was a problem hiding this comment.
with nested caches, I had a hard time knowing which thing I was dealing with when, so I added some context
NullVoxPopuli
commented
Jun 18, 2024
| @@ -186,6 +186,7 @@ export function resource<Value>( | |||
| let internalConfig: InternalFunctionResourceConfig<Value> = { | |||
| definition: context as ResourceFunction<Value>, | |||
| type: 'function-based', | |||
| name: 'Resource', | |||
There was a problem hiding this comment.
Helps with debug output when errors from Glimmer print to the console
NullVoxPopuli
commented
Jun 18, 2024
|
|
||
| function getDebugName(obj: object) { | ||
| if ('name' in obj) { | ||
| return `Resource Function: ${obj.name}`; |
There was a problem hiding this comment.
Helps with debug output when errors from Glimmer print to the console
NullVoxPopuli
commented
Jun 18, 2024
| @@ -42,15 +42,21 @@ | |||
| "allowImportingTsExtensions": true, | |||
|
|
|||
| // require extensions | |||
| "module": "Node16", | |||
| "moduleResolution": "Node16", | |||
| // "module": "Node16", | |||
There was a problem hiding this comment.
fixes local dev experience
NullVoxPopuli
commented
Jun 18, 2024
| let app = new EmberApp(defaults, { | ||
| trees: { | ||
| app: sideWatch('app', { watching: [path.join(__dirname, '../ember-resources')] }), |
There was a problem hiding this comment.
allows me to not have to restart the app when I re-compile the addon (which is an injected dependency)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1134
The issue seems specific to vanilla rendering, where your resource isn't surrounded with an if block.