Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try pnpm test waiters peer deps #413

Merged
merged 2 commits into from
Feb 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 51 additions & 21 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,19 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- run: yarn install
- run: yarn test
working-directory: ./testing/build
- name: Cache pnpm modules
uses: actions/cache@v2
with:
path: ~/.pnpm-store
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-

- uses: pnpm/[email protected]
with:
version: 6.32.1
- run: pnpm install
- run: pnpm --filter ember-resources-build-test test


tests:
Expand All @@ -41,12 +51,20 @@ jobs:
- uses: volta-cli/action@v1
with:
node-version: ${{ matrix.node }}
- name: Cache pnpm modules
uses: actions/cache@v2
with:
path: ~/.pnpm-store
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-

- run: yarn install

- uses: pnpm/[email protected]
with:
version: 6.32.1
- run: pnpm install
- name: Test with ${{ matrix.node }}
run: yarn ember test
working-directory: ./testing/ember-app
run: pnpm --filter ember-app run ember:test

# floating-dependencies:
# if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"
Expand Down Expand Up @@ -94,16 +112,23 @@ jobs:
- uses: volta-cli/action@v1
with:
node-version: 12.x
- name: install dependencies
run: yarn install
- name: Cache pnpm modules
uses: actions/cache@v2
with:
path: ~/.pnpm-store
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-

- uses: pnpm/[email protected]
with:
version: 6.32.1

- run: pnpm install
- name: test
working-directory: testing/ember-app
run: |
cd ember-resources
yarn build
yarn link
cd ../testing/ember-app
# ember-try does the other side of the link
yarn ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup

publish:
name: Release
Expand All @@ -116,15 +141,20 @@ jobs:
with:
persist-credentials: false
- uses: volta-cli/action@v1
- uses: actions/cache@v2
- name: Cache pnpm modules
uses: actions/cache@v2
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/package-lock.json') }}
- run: yarn install
path: ~/.pnpm-store
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-

- uses: pnpm/[email protected]
with:
version: 6.32.1
- run: pnpm install
- name: Release
run: yarn semantic-release
working-directory: ./ember-resources
run: pnpm --filter ember-resources exec semantic-release
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
63 changes: 47 additions & 16 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,18 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- uses: actions/cache@v2
- name: Cache pnpm modules
uses: actions/cache@v2
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
- run: yarn install
path: ~/.pnpm-store
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-

- uses: pnpm/[email protected]
with:
version: 6.32.1
run_install: true

source:
if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"
Expand All @@ -36,12 +43,20 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- uses: actions/cache@v2
- name: Cache pnpm modules
uses: actions/cache@v2
with:
path: ~/.pnpm-store
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-

- uses: pnpm/[email protected]
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
version: 6.32.1
run_install: true
- name: ESLint
run: yarn lint:js
run: pnpm run lint:js
working-directory: ./ember-resources

test_app:
Expand All @@ -53,12 +68,20 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- uses: actions/cache@v2
- name: Cache pnpm modules
uses: actions/cache@v2
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
path: ~/.pnpm-store
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-

- uses: pnpm/[email protected]
with:
version: 6.32.1
run_install: true
- name: ESLint
run: yarn lint:js
run: pnpm run lint:js
working-directory: ./testing/ember-app

tooling:
Expand All @@ -72,13 +95,21 @@ jobs:
- uses: volta-cli/action@v1
with:
node-version: 12 # min-supported
- uses: actions/cache@v2
- name: Cache pnpm modules
uses: actions/cache@v2
with:
path: ~/.pnpm-store
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-

- uses: pnpm/[email protected]
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
version: 6.32.1
run_install: true

- name: Semantic Release
run: yarn semantic-release --dry-run
run: pnpm exec semantic-release --dry-run
working-directory: ./ember-resources
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down
6 changes: 5 additions & 1 deletion ember-resources/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
},
"dependencies": {
"@embroider/addon-shim": "^1.2.0",
"@embroider/macros": "^1.2.0",
"@embroider/macros": "^1.2.0"
},
"peerDependencies": {
"@ember/test-waiters": "^3.0.0"
},
"devDependencies": {
Expand All @@ -48,6 +50,7 @@
"@babel/plugin-syntax-decorators": "7.17.0",
"@babel/plugin-transform-runtime": "^7.17.0",
"@babel/preset-typescript": "7.16.7",
"@ember/test-waiters": "^3.0.0",
"@embroider/addon-dev": "1.2.0",
"@nullvoxpopuli/eslint-configs": "^2.1.1",
"@semantic-release/changelog": "^5.0.0",
Expand Down Expand Up @@ -106,6 +109,7 @@
"@semantic-release/git"
]
},
"packageManager": "[email protected]",
"volta": {
"extends": "../package.json"
}
Expand Down
14 changes: 10 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"license": "MIT",
"author": "NullVoxPopuli",
"scripts": {
"build": "yarn workspace ember-resources build",
"build:docs": "yarn workspace docs docs:collect",
"start:docs": "yarn build:docs --watch",
"prepare": "yarn build"
"build": "pnpm run --filter ember-resources build",
"build:docs": "pnpm run --filter docs docs:collect",
"start:docs": "pnpm run build:docs --watch",
"prepare": "pnpm run build"
},
"resolutions": {
"@embroider/addon-shim": "1.2.0"
Expand All @@ -37,6 +37,12 @@
"yarn": "1.22.17",
"npm": "8.5.2"
},
"packageManager": "[email protected]",
"pnpm": {
"overrides": {
"@embroider/addon-shim": "1.2.0"
}
},
"engines": {
"node": ">= 12"
}
Expand Down
Loading