Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cell): improve typings of the cell utility #602

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Aug 27, 2022

in typescript / glint, cell will now infer the type.
when you use cell with no initial value, you'll want to explicitly declare the type, as is demonstrated in the it works cell rendering test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 27, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e3229d
Status: ✅  Deploy successful!
Preview URL: https://da5048c8.ember-resources.pages.dev
Branch Preview URL: https://improve-cell-types.ember-resources.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2022

Estimated impact to a consuming app, depending on which bundle is imported

js min min + gzip min + brotli
/index.js 12.54 kB 3.15 kB 1.28 kB 1.13 kB
├── core/class-based/index.js 4.1 kB 1.8 kB 883 B 761 B
├── core/function-based/index.js 5.71 kB 552 B 269 B 213 B
└── core/use.js 1.73 kB 415 B 256 B 203 B
/util/cell.js 1.99 kB 800 B 410 B 346 B
/util/debounce.js 2.64 kB 771 B 408 B 340 B
/util/ember-concurrency.js 4.35 kB 1.53 kB 733 B 624 B
/util/function-resource.js 216 B 154 B 123 B 87 B
/util/function.js 4.03 kB 1.78 kB 703 B 595 B
/util/helper.js 1.8 kB 303 B 218 B 177 B
/util/keep-latest.js 1.75 kB 519 B 292 B 236 B
/util/map.js 5.66 kB 2.38 kB 993 B 847 B
/util/remote-data.js 4.86 kB 1.75 kB 674 B 593 B

@NullVoxPopuli NullVoxPopuli merged commit 0a03008 into main Aug 27, 2022
@NullVoxPopuli NullVoxPopuli deleted the improve-cell-types branch August 27, 2022 18:49
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant