Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos, add links, specify use #920

Merged
merged 2 commits into from
Jun 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ jobs:
# - https://github.com/TypeStrong/typedoc/issues/2111
# - https://github.com/cloudflare/wrangler2/issues/2240
mv dist/functions dist/funcs
find ./dist -type f -name '*.html' | xargs sed -i.bak --regexp-extended 's:(href="[^"]+)functions/:\1funcs/:g'
find ./dist -type f -name '*.html' | xargs sed -i.bak --regexp-extended 's:(href="[^"]*)functions/:\1funcs/:g'

- name: Publish to Cloudflare Pages
id: publishStep
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/weekly-typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- typescript@next

steps:
Expand Down
5 changes: 4 additions & 1 deletion ember-resources/src/core/function-based/resource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ import type { InternalFunctionResourceConfig, ResourceFn, ResourceFunction } fro
* // - `cleanup`
* on,
*
* // used for composing other resources
* use,
*
* // used for accessing services, etc on the app/engine owner instance
* owner
* }) => {
Expand Down Expand Up @@ -207,7 +210,7 @@ export function resource<Value>(
}

assert(
`Mismatched argument typs passed to \`resource\`. ` +
`Mismatched argument types passed to \`resource\`. ` +
`Expected the first arg, the context, to be a type of object. This is usually the \`this\`. ` +
`Received ${typeof context} instead.`,
typeof context === 'object'
Expand Down
1 change: 1 addition & 0 deletions ember-resources/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ export { use } from './core/use';
export { cell } from 'util/cell';

// Public Type Utilities
export type { Hooks as ResourceAPI } from './core/function-based';
export type { ArgsWrapper, ExpandArgs, Thunk } from './core/types';