Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrome: Labels difficult to read in dark mode #5

Closed
marvinhagemeister opened this issue Nov 24, 2023 · 7 comments · Fixed by #11
Closed

chrome: Labels difficult to read in dark mode #5

marvinhagemeister opened this issue Nov 24, 2023 · 7 comments · Fixed by #11

Comments

@marvinhagemeister
Copy link

Best explained via a screenshot.

Screenshot 2023-11-24 at 10 46 16
@NullVoxPopuli
Copy link
Owner

NullVoxPopuli commented Nov 24, 2023 •
edited
Loading

Fixed, thanks!

If not, can you provide your browser information?

@NullVoxPopuli
Copy link
Owner

Reopening because i just found a ton of ui issues in mobile chrome

@NullVoxPopuli NullVoxPopuli reopened this Nov 24, 2023
@NullVoxPopuli
Copy link
Owner

NullVoxPopuli commented Nov 24, 2023 •
edited
Loading

Looks like this'll be fixed in

  • chrome 120 (Nov 29, 2023)
  • edge 120 (release pending)
  • safari 17.2 (release pending)
  • firefox 117 (Aug 28, 2023)

Screenshot_20231124-100738

@webpro webpro mentioned this issue Dec 11, 2023
Open
@webpro
Copy link

webpro commented Dec 11, 2023

In Chrome v120 the toggles look better, but the labels are still hard to read:

Screenshot 2023-12-11 at 9 10 44 AM

@webpro webpro mentioned this issue Dec 11, 2023
Closed
@NullVoxPopuli
Copy link
Owner

Doen your copy of Firefox have the same issues?

@webpro
Copy link

webpro commented Dec 11, 2023

No, FF v120 is fine

@NullVoxPopuli NullVoxPopuli changed the title Labels difficult to read in dark mode chrome: Labels difficult to read in dark mode Dec 11, 2023
NullVoxPopuli added a commit that referenced this issue Dec 12, 2023
@NullVoxPopuli
Fix #5 & #9
5741463
@NullVoxPopuli NullVoxPopuli mentioned this issue Dec 12, 2023
Merged
NullVoxPopuli added a commit that referenced this issue Dec 12, 2023
@NullVoxPopuli
Fix #5 & #9 (#11)
df35266
@NullVoxPopuli
Copy link
Owner

NullVoxPopuli commented Dec 12, 2023 •
edited
Loading

Fixed chrome! it turns out that the combo of Chart.JS + Chrome doesn't work with using currentColor as the axis/tick/label colors.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5 & #9 NullVoxPopuli/package-majors
3 participants
@NullVoxPopuli @webpro @marvinhagemeister