small changes

Numan52 · Feb 28, 2025 · fd3a19c · fd3a19c
1 parent 8d4271f
commit fd3a19c
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 4 deletions.
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
@@ -29,3 +29,13 @@ jobs:
         cache: maven
     - name: Build with Maven
       run: mvn -B package --file pom.xml
+
+    - name: Azure Login
+      uses: azure/login@v1
+      with:
+       creds: ${{ secrets.AZURE_CREDENTIALS }}
+
+
+    - name: deploy to Azure Spring Apps using Maven
+      run: |
+         mvn azure-spring-apps:deploy
diff --git a/src/main/java/org/example/app/Controllers/AdController.java b/src/main/java/org/example/app/Controllers/AdController.java
@@ -86,7 +86,7 @@ public ResponseEntity<?> getAds(@RequestParam int offset, @RequestParam int limi
         }
     }
 
-    // TODO: FIX MAXIMUM SIZE EXCEEDED ERROR
+
     @PostMapping(path = "/ads", consumes = {MediaType.MULTIPART_FORM_DATA_VALUE})
     public ResponseEntity<?> postAd(@RequestPart("ad") CreateAdDto createAdDto,
                                     @RequestPart(value = "images", required = false) List<MultipartFile> images,

diff --git a/src/main/java/org/example/app/Daos/AdDao.java b/src/main/java/org/example/app/Daos/AdDao.java
@@ -223,5 +223,7 @@ public void saveAdView(UserActivity userActivity) {
         entityManager.persist(userActivity);
     }
 
-
+    // TODO FINISH
+    public void updateAdView(UUID id, UUID adId) {
+    }
 }
diff --git a/src/main/java/org/example/app/Models/Entities/Ad.java b/src/main/java/org/example/app/Models/Entities/Ad.java
@@ -24,7 +24,7 @@ public class Ad {
     @Column(nullable = false)
     private float price;
 
-    // TODO: check for errors regarding length
+
     @Column(nullable = false, length = 1000)
     private String description;
 

diff --git a/src/main/java/org/example/app/Services/AdService.java b/src/main/java/org/example/app/Services/AdService.java
@@ -112,7 +112,9 @@ public void updateUserAdViews(User user, UUID adId) {
         Ad ad = adDao.getAd(adId);
 
         boolean hasSeenAd = adDao.checkIfUserSeen(user.getId(), adId);
-        if (!hasSeenAd) {
+        if (hasSeenAd) {
+            adDao.updateAdView(user.getId(), adId);
+        } else {
             adDao.saveAdView(new UserActivity(user, ad, null));
             adDao.updateViewsCount(adId);
         }