Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize app using MVP with Dagger 2 (Dependency injection) #22

Open
6 of 13 tasks
xdk78 opened this issue Jul 10, 2017 · 1 comment
Open
6 of 13 tasks

Modularize app using MVP with Dagger 2 (Dependency injection) #22

xdk78 opened this issue Jul 10, 2017 · 1 comment
Assignees
@xdk78
Labels
enhancement help wanted in progress Next Version
Milestone
v2.0

Comments

@xdk78
Copy link
Contributor

xdk78 commented Jul 10, 2017 •
edited
Loading

Current convert progress, see branch mvp https://github.com/NyaaPantsu/NyaaPantsu-android-app/tree/mvp
@xdk78 xdk78 changed the title Modulelize app using Dagger 2 Modularize app using Dagger 2 (Dependency injection) Jul 10, 2017
@akuma06
Copy link
Member

akuma06 commented Jul 10, 2017

I don't mind but won't that be overkill for the app?

@xdk78 xdk78 closed this as completed Jul 13, 2017
xdk78 added a commit that referenced this issue Feb 18, 2018
@xdk78
[W.I.P] Rewrite app to MVP with Dependency Injection part 1 #22
616bf5d
@xdk78 xdk78 reopened this Feb 18, 2018
@xdk78 xdk78 changed the title Modularize app using Dagger 2 (Dependency injection) Modularize app using MVP with Dagger 2 (Dependency injection) Feb 18, 2018
@xdk78 xdk78 self-assigned this Feb 18, 2018
This was referenced Feb 18, 2018
Closed
Closed
@xdk78 xdk78 added this to the v1.3 milestone Feb 18, 2018
xdk78 added a commit that referenced this issue Feb 21, 2018
@xdk78
[W.I.P] Rewrite app to MVP with Dependency Injection part 2 #22
e830d49
xdk78 added a commit that referenced this issue Feb 28, 2018
@xdk78
[W.I.P] Rewrite app to MVP with Dependency Injection part 3 #22
b16df45
xdk78 added a commit that referenced this issue Mar 3, 2018
@xdk78
[W.I.P] Rewrite app to MVP with Dependency Injection part 4 #22
57cdd13
xdk78 added a commit that referenced this issue Mar 4, 2018
@xdk78
[W.I.P] Rewrite app to MVP with Dependency Injection part 5 #22
f452d89
xdk78 added a commit that referenced this issue Mar 5, 2018
@xdk78
[W.I.P] Rewrite app to MVP with Dependency Injection part 6 #22
ba31464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xdk78 xdk78

Labels
enhancement help wanted in progress Next Version
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@akuma06 @xdk78