Do not use RSpec's monkey patches

.rubocop_todo.yml

@@ -1,26 +1,26 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-12-13 21:13:27 +0100 using RuboCop version 0.52.0.
+# on 2017-12-26 13:52:41 +0900 using RuboCop version 0.52.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 76
+# Offense count: 73
 Metrics/AbcSize:
   Max: 18
 
-# Offense count: 42
+# Offense count: 41
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 185
 
-# Offense count: 179
+# Offense count: 178
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 14
 
-# Offense count: 7
+# Offense count: 4
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
   Max: 139
@@ -32,18 +32,18 @@ RSpec/AnyInstance:
     - 'spec/rubocop/cop/lint/duplicate_methods_spec.rb'
     - 'spec/rubocop/target_finder_spec.rb'
 
-# Offense count: 962
+# Offense count: 963
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Enabled: false
 
-# Offense count: 2763
+# Offense count: 2790
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Enabled: false
 
-# Offense count: 41
+# Offense count: 43
 RSpec/ExpectOutput:
   Exclude:
     - 'spec/rubocop/cli/cli_auto_gen_config_spec.rb'
@@ -78,7 +78,12 @@ RSpec/MessageSpies:
     - 'spec/rubocop/formatter/progress_formatter_spec.rb'
     - 'spec/rubocop/rake_task_spec.rb'
 
-# Offense count: 864
+# Offense count: 1
+RSpec/MultipleDescribes:
+  Exclude:
+    - 'spec/rubocop/string_util_spec.rb'
+
+# Offense count: 869
 RSpec/MultipleExpectations:
   Max: 25
 
@@ -96,7 +101,7 @@ RSpec/SubjectStub:
 RSpec/VerifiedDoubles:
   Enabled: false
 
-# Offense count: 172
+# Offense count: 100
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:

spec/isolated_environment_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe 'isolated environment', :isolated_environment, type: :feature do
+RSpec.describe 'isolated environment', :isolated_environment, type: :feature do
   include_context 'cli spec behavior'
 
   let(:cli) { RuboCop::CLI.new }

spec/project_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe 'RuboCop Project', type: :feature do
+RSpec.describe 'RuboCop Project', type: :feature do
   let(:cop_names) do
     RuboCop::Cop::Cop
       .registry

spec/rubocop/ast/and_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::AndNode do
+RSpec.describe RuboCop::AST::AndNode do
   let(:and_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/args_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::ArgsNode do
+RSpec.describe RuboCop::AST::ArgsNode do
   let(:args_node) { parse_source(source).ast.arguments }
 
   describe '.new' do

spec/rubocop/ast/array_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::ArrayNode do
+RSpec.describe RuboCop::AST::ArrayNode do
   let(:array_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/block_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::BlockNode do
+RSpec.describe RuboCop::AST::BlockNode do
   let(:block_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/case_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::CaseNode do
+RSpec.describe RuboCop::AST::CaseNode do
   let(:case_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/def_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::DefNode do
+RSpec.describe RuboCop::AST::DefNode do
   let(:def_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/ensure_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::EnsureNode do
+RSpec.describe RuboCop::AST::EnsureNode do
   let(:ensure_node) { parse_source(source).ast.children.first }
 
   describe '.new' do

spec/rubocop/ast/for_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::ForNode do
+RSpec.describe RuboCop::AST::ForNode do
   let(:for_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/hash_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::HashNode do
+RSpec.describe RuboCop::AST::HashNode do
   let(:hash_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/if_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::IfNode do
+RSpec.describe RuboCop::AST::IfNode do
   let(:if_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/keyword_splat_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::KeywordSplatNode do
+RSpec.describe RuboCop::AST::KeywordSplatNode do
   let(:kwsplat_node) { parse_source(source).ast.children.last }
 
   describe '.new' do

spec/rubocop/ast/node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::Node do
+RSpec.describe RuboCop::AST::Node do
   describe '#asgn_method_call?' do
     it 'does not match ==' do
       parsed = parse_source('Object.new == value')

spec/rubocop/ast/or_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::OrNode do
+RSpec.describe RuboCop::AST::OrNode do
   let(:or_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/pair_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::PairNode do
+RSpec.describe RuboCop::AST::PairNode do
   let(:pair_node) { parse_source(source).ast.children.first }
 
   describe '.new' do

spec/rubocop/ast/regexp_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::RegexpNode do
+RSpec.describe RuboCop::AST::RegexpNode do
   let(:regexp_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/resbody_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::ResbodyNode do
+RSpec.describe RuboCop::AST::ResbodyNode do
   let(:resbody_node) do
     begin_node = parse_source(source).ast
     rescue_node, = *begin_node

spec/rubocop/ast/send_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::SendNode do
+RSpec.describe RuboCop::AST::SendNode do
   let(:send_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/str_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::StrNode do
+RSpec.describe RuboCop::AST::StrNode do
   let(:str_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/super_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::SuperNode do
+RSpec.describe RuboCop::AST::SuperNode do
   let(:super_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/symbol_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::SymbolNode do
+RSpec.describe RuboCop::AST::SymbolNode do
   let(:sym_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/until_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::UntilNode do
+RSpec.describe RuboCop::AST::UntilNode do
   let(:until_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/when_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::WhenNode do
+RSpec.describe RuboCop::AST::WhenNode do
   let(:when_node) { parse_source(source).ast.children[1] }
 
   describe '.new' do

spec/rubocop/ast/while_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::WhileNode do
+RSpec.describe RuboCop::AST::WhileNode do
   let(:while_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/ast/yield_node_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::AST::YieldNode do
+RSpec.describe RuboCop::AST::YieldNode do
   let(:yield_node) { parse_source(source).ast }
 
   describe '.new' do

spec/rubocop/cli/cli_auto_gen_config_spec.rb

@@ -2,7 +2,7 @@
 
 require 'timeout'
 
-describe RuboCop::CLI, :isolated_environment do
+RSpec.describe RuboCop::CLI, :isolated_environment do
   include_context 'cli spec behavior'
 
   subject(:cli) { described_class.new }

spec/rubocop/cli/cli_autocorrect_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::CLI, :isolated_environment do
+RSpec.describe RuboCop::CLI, :isolated_environment do
   include_context 'cli spec behavior'
 
   subject(:cli) { described_class.new }

spec/rubocop/cli/cli_options_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::CLI, :isolated_environment do
+RSpec.describe RuboCop::CLI, :isolated_environment do
   include_context 'cli spec behavior'
 
   subject(:cli) { described_class.new }

spec/rubocop/cli_spec.rb

@@ -2,7 +2,7 @@
 
 require 'timeout'
 
-describe RuboCop::CLI, :isolated_environment do
+RSpec.describe RuboCop::CLI, :isolated_environment do
   include_context 'cli spec behavior'
 
   subject(:cli) { described_class.new }

spec/rubocop/comment_config_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::CommentConfig do
+RSpec.describe RuboCop::CommentConfig do
   subject(:comment_config) { described_class.new(parse_source(source)) }
 
   describe '#cop_enabled_at_line?' do

spec/rubocop/config_loader_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::ConfigLoader do
+RSpec.describe RuboCop::ConfigLoader do
   include FileHelper
 
   let(:default_config) { described_class.default_configuration }

spec/rubocop/config_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Config do
+RSpec.describe RuboCop::Config do
   include FileHelper
 
   subject(:configuration) { described_class.new(hash, loaded_path) }

spec/rubocop/config_store_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::ConfigStore do
+RSpec.describe RuboCop::ConfigStore do
   subject(:config_store) { described_class.new }
 
   before do

spec/rubocop/cop/badge_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::Badge do
+RSpec.describe RuboCop::Cop::Badge do
   subject(:badge) { described_class.new('Test', 'ModuleMustBeAClassCop') }
 
   it 'exposes department name' do

spec/rubocop/cop/bundler/duplicated_gem_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::Bundler::DuplicatedGem, :config do
+RSpec.describe RuboCop::Cop::Bundler::DuplicatedGem, :config do
   subject(:cop) { described_class.new(config) }
 
   let(:cop_config) { { 'Include' => ['**/Gemfile'] } }

spec/rubocop/cop/bundler/insecure_protocol_source_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::Bundler::InsecureProtocolSource do
+RSpec.describe RuboCop::Cop::Bundler::InsecureProtocolSource do
   subject(:cop) { described_class.new(config) }
 
   let(:config) { RuboCop::Config.new }

spec/rubocop/cop/bundler/ordered_gems_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::Bundler::OrderedGems, :config do
+RSpec.describe RuboCop::Cop::Bundler::OrderedGems, :config do
   subject(:cop) { described_class.new(config) }
 
   let(:cop_config) do

spec/rubocop/cop/commissioner_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::Commissioner do
+RSpec.describe RuboCop::Cop::Commissioner do
   describe '#investigate' do
     let(:cop) do
       double(RuboCop::Cop, offenses: [], excluded_file?: false).as_null_object

spec/rubocop/cop/cop_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::Cop do
+RSpec.describe RuboCop::Cop::Cop do
   subject(:cop) { described_class.new }
 
   let(:location) do