Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] base_vat_optional_vies: Fix error installing vatnumber #1700

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[FIX] base_vat_optional_vies: Fix error installing vatnumber #1700

merged 1 commit into from
Jul 18, 2023

Conversation

moylop260
Copy link
Contributor

Fix #1699

@moylop260 moylop260 self-assigned this Jul 18, 2023
@moylop260 moylop260 changed the title DRAFT: [FIX] base_vat_optional_vies: Fix error installing vatnumber [FIX] base_vat_optional_vies: Fix error installing vatnumber Jul 18, 2023
@moylop260
Copy link
Contributor Author

This way fixed the issue related with runboat as you can see in this PR

cc @SirTakobi

Fast tracking since that runboat is red and it is not deploying the instance

@moylop260
Copy link
Contributor Author

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1700-by-moylop260-bump-major, awaiting test results.

sergiocorato
sergiocorato requested changes Jul 18, 2023
View reviewed changes
Copy link

@sergiocorato sergiocorato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with this solution, Odoo 14.0 is not compatible with Python 3.9+
Edit: Python version used is 3.8.x, linked issue pypa/setuptools#2086 report Python 3.10.x, why is this error happening here?

@OCA-git-bot OCA-git-bot merged commit dd20f30 into OCA:14.0 Jul 18, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d926a6e. Thanks a lot for contributing to OCA. ❤️

@moylop260
Copy link
Contributor Author

moylop260 commented Jul 18, 2023 •
edited
Loading

I disagree with this solution, Odoo 14.0 is not compatible with Python 3.9+

Runboat is using py3.8 and it is working well with this fix

  • Screenshot 2023-07-18 at 11 39 05

Feel free to revert it and create a better solution where the CI is green in a new PR

@moylop260 moylop260 deleted the 14.0-vatnum-moy branch July 18, 2023 17:40
This was referenced Jul 18, 2023
Closed
Closed
@moylop260
Copy link
Contributor Author

I meant,

https://runboat.odoo-community.org/webui/builds.html?repo=OCA/account-financial-tools&target_branch=14.0

Screenshot 2023-07-18 at 11 47 49

@moylop260 moylop260 mentioned this pull request Jul 18, 2023
Closed
@moylop260
Copy link
Contributor Author

FYI the final fix should be:

Please, feel free to take the issue

@sergiocorato
Copy link

FYI the final fix should be:

* [base_vat_optional_vies: Migrate deprecated `vatnumber` to `python-stdnum` library #1701](https://github.com/OCA/account-financial-tools/issues/1701)

Please, feel free to take the issue

Anyway it works, so it's ok. But I'll investigate later, as I use 3.8.16 and vatnumber 1.2 and they works.

@petrus-v
Copy link
Contributor

as far I've investigate and open a PR create before https://github.com/OCA/account-financial-tools/pull/1581/files that lib wasn't used anymore by this module...

@petrus-v
Copy link
Contributor

as far I've investigate and open a PR create before https://github.com/OCA/account-financial-tools/pull/1581/files that lib wasn't used anymore by this module...

in fact someone take care in the mean time... just closing PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiocorato sergiocorato sergiocorato requested changes

Assignees

@moylop260 moylop260

Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moylop260 @OCA-git-bot @sergiocorato @petrus-v