Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] resource_booking: get_intervals #136

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

norlinhenrik
Copy link

@norlinhenrik norlinhenrik commented Jul 31, 2024

Current workflow: Create a booking with a booking type, then check availablility.

Needed workflow: Check availability for a booking type without creating a booking.

_get_intervals() has a new input argument:

  • start_dt
  • end_dt
  • combination=None
  • type=None

2nd commit: maintainers. Shall I squash the commits?

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza, @ows-cloud,
some modules you are maintaining are being modified, check this out!

Now we can get intervals of an empty booking,
by specifying the needed values, including the booking type.
@norlinhenrik norlinhenrik force-pushed the 16.0-imp-resource_booking-get-intervals branch 2 times, most recently from 051bdd0 to 4a1a3e7 Compare August 6, 2024 09:05
@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 5, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use type, as it's a semi-reserved word. Use for example rb_type. Anyway, I don't get the sense of the code, as you are still assigning a booking type.

Copy link

github-actions bot commented Jan 5, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants