[17.0][MIG] contract_sale: Migration to 17.0 #1074
Conversation
* README by fragments * Adjusted dependency * Changed root menu XML-ID
[REF] Contract Sale: update translations
The lowest model access for contract.contract model is group_account_invoice group. However the addon adds two smart buttons to res.partner view without any security restrictions and without compute_sudo attribute on computed fields. This causes the view to crash when a user without the proper permissions tries to access the res.partner form view. The solution adds groups_id to the partner form views in which the buttons are added, so the only loads when the user has proper permissions. Other way to solve it would be to add compute_sudo attribute to the relevant fields, but this causes an access error when the user clicks on the smart buttons.
Currently translated at 100.0% (1 of 1 strings) Translation: contract-12.0/contract-12.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale/es_CL/
…ce: from contract_sale to contract
There was a problem hiding this comment.
Yes, looks a lot better now.
You could squash the marked commits according to:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
or in short:
git config --global --add rebase.instructionFormat "(%an <%ae>) %s"
git rebase -i origin/17.0
than replace "pick" with "f" where needed and close the file.
git push -f
jaydeep32
force-pushed
the
17.0-mig-contract_sale
branch
from
fd1b9f0 to
978b98e
Compare
|
Same changes as #1049 but clean commit history. |
|
@rousseldenis could you merge? |
|
This PR has the |
pedrobaeza
changed the title
|
/ocabot migration contract_sale |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at c7af339. Thanks a lot for contributing to OCA. ❤️ |
No description provided.