[17.0][MIG] product_contract #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add contract functionality to `product.templates` * Add logic to create contracts from `sale.order` that contains contract products.
* Change the method called in the view * Complete the create_invoice method * Bump version + authoring * Correct bad call of method Small Documentation * Add super call in python test * FIX bad field names causing bad quantities in sale.order.line
- On Sale Order confirmation, a contract is created for each contract template used on sale order lines - A not finished contract can be mentioned on sale order line - A sale order line linked to a contract will update it and don't create a new one if it had the same template
recurring_next_date should be computed by contract line to get default value
- Sale order line for contract product pass to nothing to invoice on order confirmation - Contract Invoices are linked to sale order line
…lylastday for the monthlylastday case, pre-paid is logicly impossible, if monthlylastday is set, we consider only post-paid case
jaenbox
force-pushed
the
17.0-mig-product_contract
branch
5 times, most recently
from
00c3177 to
f579c2f
Compare
jaenbox
force-pushed
the
17.0-mig-product_contract
branch
from
f579c2f to
d1602ac
Compare
mktsrl
approved these changes
May 13, 2024
Abranes
approved these changes
Jun 4, 2024
|
This PR has the |
|
/ocabot migration product_contract Have you checked v16 comments? |
I have been reviewing and yes, all the modifications indicated in the PR of 16.0 have been taken into account. |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 9865909. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"The migration of the module to version 17.0 has been completed. Several points indicated in the PR of version 16.0 have been corrected:
Migrated from #959
We have made a modification to the _get_contract_line_qty() function so that the calculation of the quantity of the line in the contract is the same as that of the sales order.