[17.0][IMP] product_contract: Set new button to configure contract

[CarlosRoca13]

With this change, we allow the user to modify the contract without going through the product configuration stage, which overwrites the product and causes the loss of some information, even when no changes are made.

Removed too the description feature because is changing the description when no option is activated. Since we have the information about what has been configured under the product, this is not a completely necessary feature. Added BTW on the ROADMAP.

cc @Tecnativa TT55066

ping @pedrobaeza @carlos-lopez-tecnativa

[OCA-git-bot]

Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

Put the removal in a separate commit.

[CarlosRoca13]

Done @pedrobaeza

[pedrobaeza]

Shouldn't you remove also the context storage thing?

[carlos-lopez-tecnativa]

Please check this error:

• Add a product with variants and a contract.
• Edit the product, confirm the variant, but cancel the contract configuration.
• The product is removed—why?
• Obviously, when trying to edit again, the error occurs because the product is empty.

[CarlosRoca13]

@pedrobaeza The storage of the context can be removed, but when changing a product attribute, the wizard's information will not be automatically filled in.

@carlos-lopez-tecnativa The issue that is occurring is that when pressing OK in the product configurator, the product is assigned regardless of whether it is changed or not. As a result, the new product process is executed. If, in a new product, the contract configuration is canceled, this causes the product not to be assigned, just as it happens with events.

[carlos-lopez-tecnativa]

@carlos-lopez-tecnativa The issue that is occurring is that when pressing OK in the product configurator, the product is assigned regardless of whether it is changed or not. As a result, the new product process is executed. If, in a new product, the contract configuration is canceled, this causes the product not to be assigned, just as it happens with events.

I understand your point, but when the record has not been saved yet, it's fine for the product to be empty.

Would it be possible to hide the buttons if no product is selected? This would prevent users from clicking and causing a traceback.

However, if the sale.order has already been saved and has an ID, canceling the wizard should not clear the product. Also, I think that on the second attempt, the Edit Configuration button should not open the contract configuration. There is now a dedicated button for that, so this should only happen when adding a new line. This change could also resolve the issue.

This is an edge case that usually doesn’t occur. I'm just testing possible scenarios based on customer feedback.

What do you think?