[14.0][IMP] website_sale_product_item_cart_custom_qty #887
Conversation
|
Hi @CarlosRoca13, |
|
Please review tests |
dessanhemrayev
force-pushed
the
14.0-t3236-website_sale_product_item_cart_custom_qty-modify
branch
5 times, most recently
from
66d1fce to
f837ef6
Compare
@CarlosRoca13 this issue is present in current runboat as well, so it's not due to this PR. Would it be possible to merge? :) |
There was a problem hiding this comment.
actually it shouldn't be merged,
@dessanhemrayev when I click on "add to cart" nothing happens
dessanhemrayev
force-pushed
the
14.0-t3236-website_sale_product_item_cart_custom_qty-modify
branch
2 times, most recently
from
1bd9b65 to
82dc425
Compare
There was a problem hiding this comment.
I think the option that has been introduced is very restrictive and should not eliminate the existing design. Previously, when the Add to cart option was active and the module installed, hovering over the products makes the buttons appear to indicate the quantity. I don’t want this to be lost.
The new feature should be just that, a new feature, but not break the previous behavior.
dessanhemrayev
force-pushed
the
14.0-t3236-website_sale_product_item_cart_custom_qty-modify
branch
from
3f6804d to
e0c8246
Compare
Add a setting in /shop page > customize: Always display qty buttons Qty and add to cart buttons are always visible (not only on rollover) To improve the visualization, move the buttons below the image so that they do not overlap it, now it occupies about 20% of the image height.
dessanhemrayev
force-pushed
the
14.0-t3236-website_sale_product_item_cart_custom_qty-modify
branch
from
e0c8246 to
5a83605
Compare
|
@CarlosRoca13 I returned the previous button behavior and combined them with the new one. Please take a look.) |
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at a3794c2. Thanks a lot for contributing to OCA. ❤️ |
ivs-cetmix
deleted the
14.0-t3236-website_sale_product_item_cart_custom_qty-modify
branch
|
@CarlosRoca13 a question: qty button is visibly unaligned with "add to cart" and "wishlist", resulting in a very "sloppy" feeling for the ecommerce:
anything that could be done to fix it? |
Hmmm... Has the add to cart any margin top? |
|
@CarlosRoca13 I'm not technical and cannot say, so I thought to ask you as maybe you know better how it works :) I see this is slightly affecting v15 (while in v16 it's fine)
|
|
I will take a look when i have a chance |
Add a setting in /shop page > customize: Always display qty buttons
Qty and add to cart buttons are always visible (not only on rollover)
To improve the visualization, move the buttons below the image so that they do not overlap it, now it occupies about 20% of the image height.