-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] website_sale_cart_expire: Migration #923
base: 17.0
Are you sure you want to change the base?
Conversation
Module that allows to automatically cancel carts without activity after a configurable time.
In a typical website flow, quotations are moved to sent state when a payment by Wire transfer is chosen. In this scenario, the quotation shouldn't be automatically cancelled. It's up to the salesman to determine when a sent quotation is expired, as technically speaking this isn't just a cart anymore.
[Fix] Use new payment.payment_provider_demo for test cases [Fix] Change acquirer_id to provider_id for test cases
Currently translated at 100.0% (14 of 14 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_cart_expire Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_cart_expire/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_cart_expire Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_cart_expire/
Before this commit, there are an issue the method raise an error if transaction_ids.last_state_change was false. It's possible for last_state_change to be false as a result of migrating data from a past Odoo DB version.
Currently translated at 100.0% (14 of 14 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_cart_expire Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_cart_expire/it/
a46663a
to
dd27f68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mantux11
I m not sure to understand why, we find a binary file (.deb) in the PR
https://github.com/OCA/e-commerce/pull/923/files#diff-de4e69c46f94e742c70468b9e0f08ebc21bf93aa8a5b98463faf63effa1e7c8a
Same for the migration v15 folder?
Functional test it's ok
@DorianMAG Hey. I don't know why there is a random file. As I see, Personally, i don't know what this file should do and why it was added in the first place. |
It must be removed in the same commit that added it. |
dd27f68
to
42bb648
Compare
@pedrobaeza file removed. |
Thanks. /ocabot migration website_sale_cart_expire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for this work
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already used in production since the creation of the PR.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Module
website_sale_cart_expire
migration to17.0
.