[16.0][MIG] hr_employee_service #1243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchpunt
force-pushed
the
16.0-mig-hr_employee_service
branch
from
5cc011c to
0f65fa4
Compare
|
Please cherry pick this PR to the migration. So the functionality is included en v16 |
mmarchpunt
changed the title
|
@nimarosa done |
mmarchpunt
force-pushed
the
16.0-mig-hr_employee_service
branch
from
ebe8c64 to
a18910d
Compare
nimarosa
approved these changes
Jun 6, 2023
|
/ocabot migration hr_employee_service |
remi-filament
suggested changes
Jun 7, 2023
There was a problem hiding this comment.
Hi @mmarchpunt thank your for this migration.
It seems there is already a PR opened for this migration : #1225 (though it does not include #1221).
Also, you did not preserve commit history from previous module which is not the expected way to migrate modules to new versions, since we would lose history, commiter names and we cannot easily compare what has really been modified in v16 (more info here : https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0)
|
@remi-filament Thanks for your input, I will fix those issues |
|
Closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.