[16.0][MIG] hr_employee_id: Migration to 16.0 #1373
Conversation
…Management modules
Initial Attempt of a port to V8 Some improvements made are as follows: * Ability so choose ID generation method * Sequence vs Random hr_employee_id: code linting and copyright removals apply suggeste changes * Use identification_id provided by hr addon rather than employee_no * use new api in configuration * pep8 changes Update res_company.py make fields assignable from res_company add tests Remove duplicate license key import openerp.exception.Warning as UserWarning [FIX] import Warning as UserWarning
* Change .py header according OCA simple header * Add parameter name on field declaration * Greenify travis * Modify README.rst. Removing tabs from xml * Remove space from xml files * Make module installable
Currently translated at 53.3% (8 of 15 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/ar/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/es/
Currently translated at 81.2% (13 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/de/
Currently translated at 81.2% (13 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/hr/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/pt_BR/
o test default values even when company fields are false o test multi-company correctness
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-15.0/hr-15.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-15.0/hr-15.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/it/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-15.0/hr-15.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/it/
maisim
force-pushed
the
16.0-mig-hr_employee_id
branch
2 times, most recently
from
2894b6c to
241af3e
Compare
|
ping @OCA/human-resources-maintainers |
|
/ocabot migration hr_employee_id |
|
The migration issue (#1141) has not been updated to reference the current pull request because a previous pull request (#1340) is not closed. |
|
Hi @alexey-pelykh ! |
|
@maisim you should do the migration commits as in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0 and do the improvements separately. As for #1340 - I'll follow the @pedrobaeza's lead here |
maisim
force-pushed
the
16.0-mig-hr_employee_id
branch
from
241af3e to
b17964b
Compare
- Updated the create method in models/hr_employee.py to not break batch mode create
- Add test : test_generate_identification_id_exception
maisim
force-pushed
the
16.0-mig-hr_employee_id
branch
from
b17964b to
fceb15b
Compare
|
I separated my changes into different commits. |
pedrobaeza
changed the title
|
There's no answer in the other PR, so let's use this one. /ocabot migration hr_employee_id |
|
✋ @gurneyalex @nimarosa @Saran440 |
|
/ocabot merge nobump Functional test okay in runnoat. Code looks good too. |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 2ebbe1a. Thanks a lot for contributing to OCA. ❤️ |
To replace #1340 wich seems stuck