[MIG] hr_employee_firstname: Migrated to 10.0 #276

espo-tony · 2016-10-28T12:33:23Z

No description provided.

LeartS

There is a superflous indentation level in the xml file left after the removal of the <data> tag, but ok for me.

njeudy

Module code look good
Module install correctly on 10 database and do the job.

pedrobaeza · 2016-11-21T12:08:46Z

hr_employee_firstname/models/hr_employee.py

-        super(HrEmployee, self)._auto_init(cr, context=context)
-        self._update_employee_names(cr, SUPERUSER_ID, context=context)
+    @api.model_cr_context
+    def _auto_init(self):


This should be done in a post_init_hook

I totally agree.
I didn't move this functionality into a post_init_hook because in the previous versions of this module _auto_init is still used. As this is just a PR for migration I thought better to keep the continuity with the previous versions. I think that changing this should be rather done in a separate pool request.
What's your opinion about this?

I think this should be done right here. Migration means sometimes a refactorization, and something that is not correct at all (this is not multi-DB aware) should be cut from the beginning.

pedrobaeza · 2016-11-21T12:09:00Z

hr_employee_firstname/__init__.py

@@ -1,23 +1 @@
-# -*- coding: utf-8 -*-


Don't remove encoding

pedrobaeza · 2016-11-21T12:09:25Z

hr_employee_firstname/i18n/hr_employee_firstname.pot

@@ -4,7 +4,7 @@
 #


Remove this file, as it's not needed and confuses when outdated.

pedrobaeza · 2016-11-21T12:10:10Z

hr_employee_firstname/tests/__init__.py

@@ -1 +1,22 @@
+# -*- coding: utf-8 -*-
+##############################################################################


Use short header: https://github.com/OCA/maintainer-tools/blob/master/template/module/__init__.py

njeudy · 2016-11-21T13:50:51Z

@pedrobaeza is there a way to commit on the same merge request ? or @espo-tony should accept me in espo-tony:10_porting_hr_employee_firstname ?

LeartS · 2016-11-21T14:00:19Z

You can do a PR against the branch of this PR in @espo-tony's repo, when he merges it this PR will automatically update

espo-tony · 2016-12-02T10:38:05Z

@pedrobaeza
In my last commit I've implemented the post_init_hook as requested.
For the runbot failure do you have any clue on what could be the problem? It doesn't seem to depend on my commit, nor on Odoo at all.

pedrobaeza · 2016-12-02T12:42:38Z

Yeah, runbot is failing due to the change in the infrastructure to Docker. It seems there's still something to fine-tune, @moylop260 and @gurneyalex...

gurneyalex · 2016-12-02T15:04:44Z

No idea... I just triggered a rebuild to see

pedrobaeza · 2016-12-02T15:15:04Z

It's also happening on l10n-spain: runbot.odoo-community.org/runbot/build/3274108

gurneyalex · 2016-12-02T15:16:31Z

could be related to OCA/runbot-addons#111

leemannd

One dependencie change & a question about the version

leemannd · 2017-01-16T09:17:48Z

hr_employee_firstname/init_hook.py

+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+from openerp import SUPERUSER_ID
+from openerp.api import Environment


s/openerp/odoo/

leemannd · 2017-01-16T09:21:25Z

hr_employee_firstname/views/hr_view.xml

+                <attribute name="invisible">1</attribute>
+                <attribute name="no_label">1</attribute>
+                <attribute name="required">0</attribute>
+            </xpath>


IMHO I find this way to do to be more readable . Just a question, is there any reason to have taken V8 of the module instead of the V9 ?

It's better to not make replace for avoiding losing other attributes (for example, a custom context), so I prefer this one.

replace imports s/openerp/odoo

leemannd · 2017-01-17T16:16:50Z

@pedrobaeza Post init_hook have been updated. Is it possible to have a review? Thank you.
@espo-tony Thanks for the port.

pedrobaeza · 2017-01-24T13:22:21Z

Please shorten headers as stated and I'll merge.

Short Headers

espo-tony · 2017-01-24T13:27:00Z

@leemannd Thank you very much for your contribution.

[BSSFL-385] Fix routes config

[MIG] hr_employee_firstname: Migrated to 10.0

5ff8c6e

espo-tony mentioned this pull request Oct 28, 2016

[MIG] hr_employee_firstname: Migrated to 10.0 #275

Closed

pedrobaeza mentioned this pull request Oct 28, 2016

Migration to version 10.0 #259

Closed

58 tasks

espo-tony added 3 commits October 28, 2016 14:56

[FIX] Code refactoring for solving Travis errors

f2100b9

[FIX] Redefine module _auto_init in order to pass the runbot.build test

336c867

[FIX] Added test case for onchange method

719061a

LeartS approved these changes Nov 7, 2016

View reviewed changes

njeudy approved these changes Nov 21, 2016

View reviewed changes

pedrobaeza requested changes Nov 21, 2016

View reviewed changes

espo-tony added 2 commits December 1, 2016 12:46

[FIX] Used short headers and remove .pot file

f7e8a58

[FIX] Removed _auto_init method and implemented a post_init_hook

438a72e

leemannd suggested changes Jan 16, 2017

View reviewed changes

leemannd and others added 2 commits January 17, 2017 16:48

imports s/openerp/odoo

3ffc664

Merge pull request #5 from leemannd/10_porting_hr_employee_firstname

4d71dd4

replace imports s/openerp/odoo

leemannd approved these changes Jan 24, 2017

View reviewed changes

Short Headers

0696090

Merge pull request #6 from leemannd/10_porting_hr_employee_firstname

6184895

Short Headers

pedrobaeza approved these changes Jan 24, 2017

View reviewed changes

pedrobaeza merged commit d087cc8 into OCA:10.0 Jan 24, 2017

espo-tony deleted the 10_porting_hr_employee_firstname branch January 24, 2017 13:27

leemannd pushed a commit to leemannd/hr that referenced this pull request Jun 12, 2017

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

0abb237

feketemihai pushed a commit to feketemihai/hr that referenced this pull request Nov 14, 2017

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

aae04df

feketemihai pushed a commit to feketemihai/hr that referenced this pull request Nov 14, 2017

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

f6a0043

feketemihai pushed a commit to feketemihai/hr that referenced this pull request Nov 16, 2017

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

bc3ddaf

sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018

Merge pull request OCA#276 from TelmoSenseFly/BSSFL-385

644abd6

[BSSFL-385] Fix routes config

i-vyshnevska pushed a commit to i-vyshnevska/hr that referenced this pull request Mar 5, 2019

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

57a9ac7

i-vyshnevska pushed a commit to i-vyshnevska/hr that referenced this pull request Mar 12, 2019

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

544a334

quentingigon pushed a commit to quentingigon/hr that referenced this pull request Oct 11, 2019

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

8f8124d

luistorresm pushed a commit to vauxoo-dev/hr that referenced this pull request Oct 12, 2020

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

215f0d8

komsan-S pushed a commit to ecosoft-odoo/hr that referenced this pull request Nov 10, 2020

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

ccdbbd9

luistorresm pushed a commit to vauxoo-dev/hr that referenced this pull request Oct 18, 2021

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

e7e678c

luistorresm pushed a commit to vauxoo-dev/hr that referenced this pull request Oct 19, 2021

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

a18bcea

luistorresm pushed a commit to vauxoo-dev/hr that referenced this pull request Nov 5, 2022

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

fbf1b45

andreagidaltig pushed a commit to vauxoo-dev/hr that referenced this pull request Nov 6, 2023

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

09e929f

andreagidaltig pushed a commit to vauxoo-dev/hr that referenced this pull request Nov 8, 2023

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

83e037d

luisg123v pushed a commit to Vauxoo/hr that referenced this pull request Nov 14, 2023

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

0d93a12

andreagidaltig pushed a commit to vauxoo-dev/hr that referenced this pull request Nov 16, 2023

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

3398545

andreagidaltig pushed a commit to vauxoo-dev/hr that referenced this pull request Nov 16, 2023

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

adb967f

edy1192 pushed a commit to vauxoo-dev/hr that referenced this pull request Oct 30, 2024

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

b2e60ec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] hr_employee_firstname: Migrated to 10.0 #276

[MIG] hr_employee_firstname: Migrated to 10.0 #276

espo-tony commented Oct 28, 2016

LeartS left a comment •

edited

Loading

njeudy left a comment

pedrobaeza Nov 21, 2016

espo-tony Dec 1, 2016

pedrobaeza Dec 1, 2016

pedrobaeza Nov 21, 2016

pedrobaeza Nov 21, 2016

pedrobaeza Nov 21, 2016

njeudy commented Nov 21, 2016

LeartS commented Nov 21, 2016

espo-tony commented Dec 2, 2016

pedrobaeza commented Dec 2, 2016

gurneyalex commented Dec 2, 2016

pedrobaeza commented Dec 2, 2016

gurneyalex commented Dec 2, 2016

leemannd left a comment

leemannd Jan 16, 2017

leemannd Jan 16, 2017

pedrobaeza Jan 24, 2017

leemannd commented Jan 17, 2017

pedrobaeza commented Jan 24, 2017

espo-tony commented Jan 24, 2017

		@@ -1 +1,22 @@
		# -- coding: utf-8 --
		##############################################################################

[MIG] hr_employee_firstname: Migrated to 10.0 #276

[MIG] hr_employee_firstname: Migrated to 10.0 #276

Conversation

espo-tony commented Oct 28, 2016

LeartS left a comment • edited Loading

Choose a reason for hiding this comment

njeudy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

njeudy commented Nov 21, 2016

LeartS commented Nov 21, 2016

espo-tony commented Dec 2, 2016

pedrobaeza commented Dec 2, 2016

gurneyalex commented Dec 2, 2016

pedrobaeza commented Dec 2, 2016

gurneyalex commented Dec 2, 2016

leemannd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leemannd commented Jan 17, 2017

pedrobaeza commented Jan 24, 2017

espo-tony commented Jan 24, 2017

LeartS left a comment •

edited

Loading