Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] mrp_component_operation #1455

Open
wants to merge 34 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] mrp_component_operation #1455

wants to merge 34 commits into from
+2,353 −0

Conversation

ThiagoMForgeFlow
Copy link
Contributor

@ThiagoMForgeFlow ThiagoMForgeFlow commented Jan 14, 2025 •
edited
Loading

@ThiagoMForgeFlow ThiagoMForgeFlow mentioned this pull request Jan 15, 2025
Open
@LoisRForgeFlow
Copy link
Contributor

@ThiagoMForgeFlow dependency merged

@ThiagoMForgeFlow ThiagoMForgeFlow force-pushed the 17.0-mig-mrp_component_operation branch 2 times, most recently from 84c73fa to c7b0637 Compare January 16, 2025 08:16
@ThiagoMForgeFlow ThiagoMForgeFlow force-pushed the 17.0-mig-mrp_component_operation branch 2 times, most recently from 6928524 to c26d31d Compare January 20, 2025 11:47
@ThiagoMForgeFlow ThiagoMForgeFlow force-pushed the 17.0-mig-mrp_component_operation branch from c26d31d to 58a614d Compare January 22, 2025 10:01
DavidJForgeFlow and others added 21 commits January 31, 2025 11:22
@DavidJForgeFlow @ThiagoMForgeFlow
[14.0][ADD] mrp_component_operation
d412919
@ThiagoMForgeFlow
[UPD] Update mrp_component_operation.pot
a54e9df
@OCA-git-bot @ThiagoMForgeFlow
[UPD] README.rst
95912c6
@OCA-git-bot @ThiagoMForgeFlow
[ADD] icon.png
9c6418b
@mymage @ThiagoMForgeFlow
Added translation using Weblate (Italian)
4b4fb03
@mymage @ThiagoMForgeFlow
Translated using Weblate (Italian)
4506c0c 
Currently translated at 97.8% (45 of 46 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
@LoisRForgeFlow @ThiagoMForgeFlow
[FIX] mrp_component_operation: manufacturing users to use wizard.
b3dbd96 
Manufacturing users should be allowed to operate components and
therefore they need to be able to create and write the wizard
model.
@mymage @ThiagoMForgeFlow
Translated using Weblate (Italian)
0440b7e 
Currently translated at 100.0% (46 of 46 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
@OCA-git-bot @ThiagoMForgeFlow
mrp_component_operation 14.0.1.0.1
8903577
@DavidJForgeFlow @ThiagoMForgeFlow
[FIX] mrp_component_operation: fix test and small issues
bf4ce45
@OCA-git-bot @ThiagoMForgeFlow
mrp_component_operation 14.0.1.0.2
c0ef6ca
@francesco-ooops @ThiagoMForgeFlow
Translated using Weblate (Italian)
a60bd6d 
Currently translated at 100.0% (46 of 46 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
@mymage @ThiagoMForgeFlow
Translated using Weblate (Italian)
a96fca1 
Currently translated at 100.0% (46 of 46 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
@mymage @ThiagoMForgeFlow
Translated using Weblate (Italian)
a2a4e4d 
Currently translated at 100.0% (46 of 46 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
@francesco-ooops @ThiagoMForgeFlow
Translated using Weblate (Italian)
07d2a89 
Currently translated at 100.0% (46 of 46 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
@LoisRForgeFlow @ThiagoMForgeFlow
[IMP] mrp_component_operation: enhance extensibility of scrap vals
87d3ffc 
aditionally some adjustments have been done:
- create_date is a magic field, no need to include it in the vals.
- production_id is the inverse name of mo_id.scrap_ids.
@OCA-git-bot @ThiagoMForgeFlow
[UPD] README.rst
51ae9b0
@OCA-git-bot @ThiagoMForgeFlow
mrp_component_operation 14.0.1.0.3
48b7d71
@DavidJForgeFlow @ThiagoMForgeFlow
[IMP] mrp_component_operation: filter by picking type
76ff535
@ThiagoMForgeFlow
[UPD] Update mrp_component_operation.pot
5068342
@OCA-git-bot @ThiagoMForgeFlow
mrp_component_operation 14.0.1.1.0
6b3ca8f
weblate and others added 12 commits January 31, 2025 11:22
@weblate @ThiagoMForgeFlow
Update translation files
f49e5ac 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/
@mymage @ThiagoMForgeFlow
Translated using Weblate (Italian)
c58f208 
Currently translated at 100.0% (49 of 49 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
@OCA-git-bot @ThiagoMForgeFlow
[UPD] README.rst
6455cf3
@mymage @ThiagoMForgeFlow
Translated using Weblate (Italian)
ec4d782 
Currently translated at 100.0% (49 of 49 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
@mymage @ThiagoMForgeFlow
Translated using Weblate (Italian)
d5c98b1 
Currently translated at 100.0% (49 of 49 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
@Ivorra78 @ThiagoMForgeFlow
Added translation using Weblate (Spanish)
c8c931a
@Ivorra78 @ThiagoMForgeFlow
Translated using Weblate (Spanish)
127a265 
Currently translated at 100.0% (49 of 49 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/es/
@LoisRForgeFlow @ThiagoMForgeFlow
[IMP] mrp_component_operation: add active field
d19479b
@ThiagoMForgeFlow
[UPD] Update mrp_component_operation.pot
9b02554
@OCA-git-bot @ThiagoMForgeFlow
[BOT] post-merge updates
c670951
@weblate @ThiagoMForgeFlow
Update translation files
65ec80c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/
@ThiagoMForgeFlow
[IMP] mrp_component_operation: pre-commit auto fixes
e19859c
@ThiagoMForgeFlow ThiagoMForgeFlow force-pushed the 17.0-mig-mrp_component_operation branch from 58a614d to 5e02764 Compare January 31, 2025 10:23
DavidJForgeFlow
DavidJForgeFlow suggested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the mistaking approval, I have encountered some errors.

mrp_component_operation/views/mrp_component_operation_views.xml Outdated Show resolved Hide resolved
mrp_component_operation/wizards/mrp_component_operate.py
def _run_outgoing_operations(self):
res = []
if self.outgoing_operation == "scrap":
res = self._create_scrap()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scrap operation does not unreserve units in v17 maybe you should add part of the code below that unreserves units.

            move = self.mo_id.move_raw_ids.move_line_ids.filtered(
                lambda x: x.product_id == self.product_id
                and (x.lot_id == self.lot_id or self.lot_id is False)
            )
            if move.quantity_product_uom == self.product_qty:
                move.unlink()
            else:
                move.write({
                        "quantity_product_uom": (
                            move.quantity_product_uom - self.product_qty
                        ),
                    }
                )
                move.move_id._recompute_state()

In v14 worked fine, so I supose there must be a change in how odoo creates scraps.

@ThiagoMForgeFlow ThiagoMForgeFlow force-pushed the 17.0-mig-mrp_component_operation branch from 5e02764 to daedbd4 Compare January 31, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow left review comments

@DavidJForgeFlow DavidJForgeFlow DavidJForgeFlow requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ThiagoMForgeFlow @LoisRForgeFlow @DavidJForgeFlow @OCA-git-bot @mymage @francesco-ooops @weblate @Ivorra78