Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore build and dist directories in linters #215

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Ignore build and dist directories in linters #215

merged 1 commit into from
Oct 28, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 28, 2023

These directories are typically the output of python build tools. The are already ignored in .gitignore.

@sbidoul sbidoul mentioned this pull request Oct 28, 2023
Open
33 tasks
pedrobaeza
pedrobaeza approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we remove the P2.7 test already for having green CI?

@sbidoul sbidoul merged commit 881c1b9 into OCA:master Oct 28, 2023
@sbidoul sbidoul deleted the ignore-build-dist-sbi branch October 28, 2023 11:54
@yajo
Copy link
Member

yajo commented Oct 30, 2023

Do we really need to ignore them here if they are ignored in .gitignore? Doesn't pre-commit already respect .gitignore automatically? 🤔

@sbidoul
Copy link
Member Author

sbidoul commented Oct 30, 2023

I did not know pre-commit did that. But I did have pylint-odoo problems without this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sbidoul @yajo @rvalyi @pedrobaeza @OCA-git-bot