Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor wheel builder #212

Merged
merged 5 commits into from
Oct 2, 2022
Merged

Refactor wheel builder #212

merged 5 commits into from
Oct 2, 2022

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Sep 27, 2022 •
edited
Loading

  • reuse the build environment for performance (and stability if/when we pin build tools versions)
  • support (and give priority to) pyproject.toml in addon directories, towards removing the setup directories

TODO

  • test with a pyproject-enabled addon

@sbidoul
Refactor wheel builder
497b4c0
@sbidoul
wheel builder: make build tools configurables
752ad55 
Plus, add tests.
@sbidoul
A description is required
2f560c7 
Otherwise twine check complains.
Before, setuptools injected UNKNOWN.
@sbidoul
Silence pytest warning
7b19604
@sbidoul sbidoul marked this pull request as ready for review October 2, 2022 11:08
@sbidoul
Ignore pyproject.toml for Odoo 11 too
d02594f 
Because we want a py2.py3 wheel.
@sbidoul
Copy link
Member Author

sbidoul commented Oct 2, 2022

I'll merge this, deploy and monitor. This should be fully backward compatible.

@sbidoul sbidoul merged commit fa7ea79 into OCA:master Oct 2, 2022
@sbidoul sbidoul deleted the ref-wheel-builder-sbi branch October 2, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbidoul