Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention maintainer when his module is modified #77

Merged
merged 1 commit into from
Oct 27, 2019
Merged

Mention maintainer when his module is modified #77

merged 1 commit into from
Oct 27, 2019

Conversation

SimoRubi
Copy link
Member

Closing #63

@SimoRubi SimoRubi force-pushed the issue63 branch 2 times, most recently from 07d1605 to fd7ece0 Compare October 3, 2019 16:21
@SimoRubi SimoRubi requested a review from sbidoul October 3, 2019 16:42
@sbidoul sbidoul added enhancement New feature or request Bot Task A task the bot does or should do labels Oct 7, 2019
@sbidoul
Copy link
Member

sbidoul commented Oct 18, 2019

@SimoRubi would you mind rebasing this? There is a conflict (sorry) following a rework of subprocess calls for better error handling and Sentry support. It should be quite easy.

@SimoRubi
Copy link
Member Author

@SimoRubi would you mind rebasing this? There is a conflict (sorry) following a rework of subprocess calls for better error handling and Sentry support. It should be quite easy.

Fixing the mock tests was less easy than expected, anyway here it is and squashed in only one commit

@sbidoul
Copy link
Member

sbidoul commented Oct 27, 2019

Great job, thanks!

@sbidoul
Copy link
Member

sbidoul commented Oct 27, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch master-ocabot-merge-pr-77-by-sbidoul-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 27, 2019
@OCA-git-bot
Merge PR #77 into master
15c05c3 
Signed-off-by sbidoul
@OCA-git-bot OCA-git-bot merged commit cbd55ba into OCA:master Oct 27, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 15c05c3. Thanks a lot for contributing to OCA. ❤️

@sbidoul
Copy link
Member

sbidoul commented Oct 27, 2019

deployed

@sbidoul sbidoul mentioned this pull request Oct 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul Awaiting requested review from sbidoul

Assignees
No one assigned
Labels
Bot Task A task the bot does or should do enhancement New feature or request merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimoRubi @sbidoul @OCA-git-bot