-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] hr_payroll_document: Migration to 17.0 #152
base: 17.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (32 of 32 strings) Translation: payroll-16.0/payroll-16.0-hr_payroll_document Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-hr_payroll_document/it/
Hi @nimarosa, @appstogrow, |
1832f37
to
fa77b83
Compare
e37357e
to
d55c79f
Compare
Hi @peluko00 , I have tried to test the module with the pdf document that comes in the tests but I get this notification "Employees not found". It would be nice to add a usage section in the Readme. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Hi @nimarosa, can you reopen the pr? |
Hi @nimarosa, @appstogrow, |
Thanks!. Can you review it @nimarosa ? |
d55c79f
to
aa4d320
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the changes to the unrelated payroll
module.
Changes introduced that are not strictly related to the migration are better in a separate commit. That helps understanding the changes and backporting them.
64e890c
to
a427f73
Compare
a427f73
to
0d34649
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it is OK for me.
But reading the description I have no idea what this does and what it is useful for.
A better and more instructional README would be nice.
Module migrated to version 17.0
cc https://github.com/APSL 155370
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review
New improvements: