Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] hr_payroll_document: Migration to 17.0 #152

Open
wants to merge 7 commits into
base: 17.0
Choose a base branch
from

Conversation

peluko00
Copy link

@peluko00 peluko00 commented May 20, 2024

Module migrated to version 17.0

cc https://github.com/APSL 155370
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review

New improvements:

  • New menu item to access to full payrolls of all employees into a new view
  • Button in each employee form to filter the payrolls by the specific employee with counter and the same button for the user

@OCA-git-bot
Copy link
Contributor

Hi @nimarosa, @appstogrow,
some modules you are maintaining are being modified, check this out!

@peluko00 peluko00 force-pushed the 17.0-mig-hr_payroll_document branch from 1832f37 to fa77b83 Compare May 20, 2024 14:20
@peluko00 peluko00 mentioned this pull request May 21, 2024
2 tasks
@peluko00 peluko00 force-pushed the 17.0-mig-hr_payroll_document branch 2 times, most recently from e37357e to d55c79f Compare May 21, 2024 15:36
@lbarry-apsl
Copy link
Member

Hi @peluko00 ,

I have tried to test the module with the pdf document that comes in the tests but I get this notification "Employees not found".

It would be nice to add a usage section in the Readme.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@github-actions github-actions bot closed this Nov 3, 2024
@peluko00
Copy link
Author

peluko00 commented Nov 4, 2024

Hi @nimarosa, can you reopen the pr?

@nimarosa nimarosa reopened this Nov 4, 2024
@OCA-git-bot
Copy link
Contributor

Hi @nimarosa, @appstogrow,
some modules you are maintaining are being modified, check this out!

@nimarosa nimarosa removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 4, 2024
@peluko00
Copy link
Author

peluko00 commented Nov 4, 2024

Thanks!. Can you review it @nimarosa ?

@peluko00 peluko00 force-pushed the 17.0-mig-hr_payroll_document branch from d55c79f to aa4d320 Compare November 4, 2024 09:30
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changes to the unrelated payroll module.
Changes introduced that are not strictly related to the migration are better in a separate commit. That helps understanding the changes and backporting them.

@peluko00 peluko00 force-pushed the 17.0-mig-hr_payroll_document branch from 64e890c to a427f73 Compare January 7, 2025 07:25
@peluko00 peluko00 force-pushed the 17.0-mig-hr_payroll_document branch from a427f73 to 0d34649 Compare January 7, 2025 07:25
@peluko00
Copy link
Author

peluko00 commented Jan 7, 2025

Please remove the changes to the unrelated payroll module. Changes introduced that are not strictly related to the migration are better in a separate commit. That helps understanding the changes and backporting them.

Done, thanks! Can you review it please @dreispt @nimarosa ?

Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it is OK for me.

But reading the description I have no idea what this does and what it is useful for.
A better and more instructional README would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants