-
-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] product_status: Migration to 18.0 #1796
Open
natuan9
wants to merge
16
commits into
OCA:18.0
Choose a base branch
from
natuan9:18.0-mig-product_status
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, one remark
natuan9
force-pushed
the
18.0-mig-product_status
branch
from
December 11, 2024 08:29
9aa1449
to
9912949
Compare
sebalix
reviewed
Dec 24, 2024
/ocabot migration product_status |
natuan9
force-pushed
the
18.0-mig-product_status
branch
2 times, most recently
from
December 25, 2024 03:27
bda785d
to
8314dec
Compare
Before this change a product would never get back into its default state. Example: a new proudct with a new until date in the past will keep a state set as `new`. Instead it should be set to the default status.
natuan9
force-pushed
the
18.0-mig-product_status
branch
from
December 25, 2024 03:30
8314dec
to
6eb32fb
Compare
jbaudoux
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sebalix
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend: