[16.0][MIG+IMP] product_category_code_unique: restriciton options #1829
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_category_code_unique Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_category_code_unique/it/
manuelregidor
force-pushed
the
16.0-mig-product_category_code_unique
branch
from
3df71c1 to
49d1df1
Compare
|
@Tisho99 Could you reviw again, please? |
|
This PR has the |
|
/ocabot migration product_category_code_unique |
|
@manuelregidor Could you maybe split the migration changes from improvements in commits ? |
| self.ensure_one() | ||
| return self._get_parents() + self._get_children() | ||
|
|
||
| def _code_restriction(self, restriction=False): |
There was a problem hiding this comment.
IMHO, the restriction attribute is not useful.
There was a problem hiding this comment.
The restriction attribute has been added so it can be passed when the method is called from _check_product_cat_code_unique_restriction in res.config.settings model. _check_product_cat_code_unique_restriction in res.config.settings is executed before the system parameter is modified changed, so we need to pass the selected restriction to the _code_restriction method in product.category to check whether the restriction option can be changed.
| to_check = cat._get_hierarchy_cats() | ||
| domain = [("code", "=", cat.code), ("id", "in", to_check.ids)] | ||
| within = _("category hierarchy") | ||
| if self.search_count(domain) > 1: |
There was a problem hiding this comment.
IMHO, this should be avoided for performance reasons.
A query to get all the categories should be done outside the loop. Then, compare the recordset values.
There was a problem hiding this comment.
Sorry, but I don't know exactly what you mean here.
manuelregidor
force-pushed
the
16.0-mig-product_category_code_unique
branch
from
49d1df1 to
d7949da
Compare
|
@rousseldenis Thanks for your feedback. I've already split the changes into 2 commits. |
Based on #1750
T-6836