[17.0][MIG] product_variant_configurator: Migration to 17.0 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module has been ported from the odoomrp repo. the module name in the odoo mrp repo was product_variants_no_automatic_creation the following improvement where done while porting this module: * Improve the readme file with a technical description on how the module should be used with other modules. * Add attribute col=4 to group parent for a better desplay of product category for view. * Remove unnecessary @api.multi before compute or onchange methods. * Move product.configurator.attribute model to the new product_configurator_attribute.py file. * Add unit test for product.configurator.attribute model that includes test for _compute_possible_value_ids and _compute_price_extra methods. * Rename XML files in views and security folder as per OCA guidelines. * Improve test coverage for product_configurator. * Add unit test for purchase.order and purchase.order.line models. * Separate the purchase.order and purchase.order.line models code into two files. * Rename XML files as per OCA guidelines. * product_variant_configurator: set product_tmpl_id in onchange_product_id_product_configurator_old_api and onchange_product_id_product_configurator methods for product.configurator model. * Add unit test for onchange_product_tmpl_id and onchange_product_attribute_ids.
…doomrp repo. the following improvements were done while porting this module: * Adapt files as per OCA guidelines. * Add unit test
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
because I don't know how to emulate a true onchange that populates _origin
… are for sale only plus, fix the visibility rule of the button, to show the button if there are attributes on the product (otherwise it would stay hidden until the first 2 variants have been created) [FIX] more robust configurator onchanges [FIX] return values for onchange_product_attribute_ids
…vepoint to discard created product variant in case of exception
* Issue with cache invalidation on create * remove unused _create_variant_from_vals * hide price_extra not applicable to purchase for now
* remove import on removed procurement_order.py file * Fix tests in purchase_product_variant_configurator * Fix tests in product_variant_configurator
…elete' attribute on the field owner_id declared as Integer is required since this field is declared as inverse of the field product_attribute_ids of the abstract model product.configurator
…f.attribute_line_ids/not tmpl.attribute_line_ids
With this, you can decide at product level which attributes are required to be filled. Default is true for keeping the same logic with previous version.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Co-authored-by: Alexandra Bottemanne TT46596
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-variant-16.0/product-variant-16.0-product_variant_configurator Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_configurator/
Currently translated at 100.0% (113 of 113 strings) Translation: product-variant-16.0/product-variant-16.0-product_variant_configurator Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_configurator/it/
…o Production/Stable
Currently translated at 8.8% (10 of 113 strings) Translation: product-variant-16.0/product-variant-16.0-product_variant_configurator Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_configurator/pt_BR/
Currently translated at 12.3% (14 of 113 strings) Translation: product-variant-16.0/product-variant-16.0-product_variant_configurator Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_configurator/pt_BR/
|
/ocabot migration product_variant_configurator |
Jaimermaccione
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
LGTM! Functional test on Runboat.
The functionality works well as tested on Runboat.
Just a note that some terminology in the README does not exactly match what is seen in Runboat, but this inconsistency is also present in previous versions. I've attached a screenshot with the correct terms highlighted in red for reference.
manuelregidor
force-pushed
the
17.0-mig-product_variant_configurator
branch
from
66a1c81 to
516d71a
Compare
|
@Jaimermaccione Done. Thank you. |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at d064127. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #350
Standard migration
T-6149